From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] docs: document how to configure the qcow2 L2/refcount caches
Date: Fri, 05 Jun 2015 18:13:49 +0200 [thread overview]
Message-ID: <5571CABD.9050501@redhat.com> (raw)
In-Reply-To: <w511thq16oy.fsf@maestria.local.igalia.com>
On 05.06.2015 18:05, Alberto Garcia wrote:
> On Fri 05 Jun 2015 06:00:17 PM CEST, Max Reitz wrote:
>
>>>> I'd like a definition of what "unused" means (I know because of this
>>>> series, but I wouldn't know just from this document).
>>> It means that it hasn't been accessed in that interval (because it
>>> was not needed). Are you thinking of any other possible
>>> interpretation?
>> Well... To me, intuitively, "unused" entries in a cache are just empty
>> entries. Just replacing one occurrence of "unused" by "not accessed
>> during the past interval" or something like that would resolve the
>> riddle for me. :-)
> Ok, I see what you mean... I used the same wording in the
> block-core.json description and in the .help field of the
> cache-clean-interval option.
>
> Do you want me to change those as well or is it enough if I clarify it
> in this document?
I think it should be fine just doing it here, because if someone is
confused by the QMP documentation, they can fall back to this document.
Max
next prev parent reply other threads:[~2015-06-05 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 12:22 [Qemu-devel] [PATCH v5 0/4] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-06-02 12:22 ` [Qemu-devel] [PATCH 1/4] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-06-05 15:47 ` Max Reitz
2015-06-02 12:22 ` [Qemu-devel] [PATCH 2/4] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-06-05 15:48 ` Max Reitz
2015-06-02 12:22 ` [Qemu-devel] [PATCH 3/4] docs: document how to configure the qcow2 L2/refcount caches Alberto Garcia
2015-06-05 15:52 ` Max Reitz
2015-06-05 15:56 ` Alberto Garcia
2015-06-05 16:00 ` Max Reitz
2015-06-05 16:05 ` Alberto Garcia
2015-06-05 16:13 ` Max Reitz [this message]
2015-06-02 12:22 ` [Qemu-devel] [PATCH 4/4] qcow2: reorder fields in Qcow2CachedTable to reduce padding Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5571CABD.9050501@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).