From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0vOq-0004W6-R6 for qemu-devel@nongnu.org; Fri, 05 Jun 2015 13:27:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0vOp-0006ce-Rb for qemu-devel@nongnu.org; Fri, 05 Jun 2015 13:27:20 -0400 Message-ID: <5571DBEE.4010203@redhat.com> Date: Fri, 05 Jun 2015 19:27:10 +0200 From: Max Reitz MIME-Version: 1.0 References: <1433454372-16356-1-git-send-email-jsnow@redhat.com> <1433454372-16356-5-git-send-email-jsnow@redhat.com> In-Reply-To: <1433454372-16356-5-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 04/10] block: re-add BlkTransactionState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, vsementsov@parallels.com, stefanha@redhat.com On 04.06.2015 23:46, John Snow wrote: > Now that the structure formerly known as BlkTransactionState has been > renamed to something sensible (BlkActionState), re-introduce an actual > BlkTransactionState that actually manages state for the entire Transaction. > > In the process, convert the old QSIMPLEQ list of actions into a QTAILQ, > to let us more efficiently delete items in arbitrary order, which will > be more important in the future when some actions will expire at the end > of the transaction, but others may persist until all callbacks triggered > by the transaction are recollected. > > Signed-off-by: John Snow > --- > blockdev.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 56 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz