From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0vTT-0005ne-Ix for qemu-devel@nongnu.org; Fri, 05 Jun 2015 13:32:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0vTS-0001Ti-Oh for qemu-devel@nongnu.org; Fri, 05 Jun 2015 13:32:07 -0400 Message-ID: <5571DD0C.6000209@redhat.com> Date: Fri, 05 Jun 2015 19:31:56 +0200 From: Max Reitz MIME-Version: 1.0 References: <1433454372-16356-1-git-send-email-jsnow@redhat.com> <1433454372-16356-8-git-send-email-jsnow@redhat.com> In-Reply-To: <1433454372-16356-8-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 07/10] qmp: Add an implementation wrapper for qmp_drive_backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, vsementsov@parallels.com, stefanha@redhat.com On 04.06.2015 23:46, John Snow wrote: > We'd like to be able to specify the callback given to backup_start > manually in the case of transactions, so split apart qmp_drive_backup > into an implementation and a wrapper. > > Switch drive_backup_prepare to use the new wrapper, but don't overload > the callback and closure yet. > > Signed-off-by: John Snow > --- > blockdev.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++---------------- > 1 file changed, 57 insertions(+), 19 deletions(-) Reviewed-by: Max Reitz