From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Z0yRh-00043D-Px
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 16:42:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Z0yRc-00083R-Qf
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 16:42:29 -0400
Received: from e17.ny.us.ibm.com ([129.33.205.207]:34045)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Z0yRc-00082O-Mg
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 16:42:24 -0400
Received: from /spool/local
	by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Fri, 5 Jun 2015 16:42:23 -0400
Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com
	[9.57.198.28])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 66316C90046
	for <qemu-devel@nongnu.org>; Fri,  5 Jun 2015 16:33:28 -0400 (EDT)
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t55KgLs457278648
	for <qemu-devel@nongnu.org>; Fri, 5 Jun 2015 20:42:21 GMT
Received: from d01av02.pok.ibm.com (localhost [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t55KgKnj031886
	for <qemu-devel@nongnu.org>; Fri, 5 Jun 2015 16:42:21 -0400
Message-ID: <557209AC.5040701@linux.vnet.ibm.com>
Date: Fri, 05 Jun 2015 16:42:20 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1433097192-8988-1-git-send-email-mst@redhat.com>
	<1433097192-8988-49-git-send-email-mst@redhat.com>
	<20150604155720.098d4b19@igors-macbook-pro.local>
In-Reply-To: <20150604155720.098d4b19@igors-macbook-pro.local>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 48/57] TPM2 ACPI table support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On 06/04/2015 09:57 AM, Igor Mammedov wrote:
> On Sun, 31 May 2015 20:37:28 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> From: Stefan Berger <stefanb@linux.vnet.ibm.com>
> [...]
>> diff --git a/hw/i386/ssdt-tpm.dsl b/hw/i386/ssdt-tpm.dsl
>> index 75d9691..d81478c 100644
>> --- a/hw/i386/ssdt-tpm.dsl
>> +++ b/hw/i386/ssdt-tpm.dsl
>> @@ -25,19 +25,5 @@ DefinitionBlock (
>>       0x1                 // OEM Revision
>>       )
>>   {
>> -    Scope(\_SB) {
>> -        /* TPM with emulated TPM TIS interface */
>> -        Device (TPM) {
>> -            Name (_HID, EisaID ("PNP0C31"))
>> -            Name (_CRS, ResourceTemplate ()
>> -            {
>> -                Memory32Fixed (ReadWrite, TPM_TIS_ADDR_BASE,
>> TPM_TIS_ADDR_SIZE)
>> -                // older Linux tpm_tis drivers do not work with IRQ
>> -                //IRQNoFlags () {TPM_TIS_IRQ}
>> -            })
>> -            Method (_STA, 0, NotSerialized) {
>> -                Return (0x0F)
>> -            }
>> -        }
>> -    }
>> +#include "ssdt-tpm-common.dsl"
> Stefan,
>
> Original TPM had IRQNoFlags commented out but looking at current master
>
> hw/i386/ssdt-tpm.dsl:
> ...
> {
> #include "ssdt-tpm-common.dsl"
> }
>
> hw/i386/ssdt-tpm-common.dsl:
> ...
> * Common parts for TPM 1.2 and TPM 2 (with slight differences for PPI)
> ...
>          Device (TPM) {
>              Name (_HID, EisaID ("PNP0C31"))
>              Name (_CRS, ResourceTemplate ()
>              {
>                  Memory32Fixed (ReadWrite, TPM_TIS_ADDR_BASE, TPM_TIS_ADDR_SIZE)
>                  IRQNoFlags () {TPM_TIS_IRQ}
>              })
> and TMP2 template includes the same ssdt-tpm-common.dsl so cited
> difference in comment above is gone now which makes TPM and TPM2
> the same.
> Was it intended change or we have introduced a bug?
>

This was an intended change. Once the physical presence interface code 
is added, there will be a difference between the two.