From: Eric Blake <eblake@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
libvir-list@redhat.com, qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently)
Date: Fri, 05 Jun 2015 15:47:49 -0600 [thread overview]
Message-ID: <55721905.2040307@redhat.com> (raw)
In-Reply-To: <557217CF.4090907@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On 06/05/2015 03:42 PM, Laszlo Ersek wrote:
> I found this qemu commit, ie.
>
> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
> Author: Markus Armbruster <armbru@redhat.com>
> Date: Thu Mar 5 14:35:26 2015 +0100
>
> monitor: Drop broken, unused asynchronous command interface
>
> with bisection. Unfortunately, the bisection was extremely painful, because between a working version and today's pull, part of the qemu history was uncompileable. It was ultimately fixed with
> Which tells me that it's not individual capabilities that are broken by qemu 65207c59, but the entire libvirt capability retrieval. Apparently libvirt is one user of that async monitor interface. (The message on commit 65207c59 itself mentions "qmp_capabilities".)
Libvirt doesn't use async capabilities, so much as Markus accidentally
broke the QMP protocol by completely ditching support for the "id"
member that libvirt uses on every synchronous QMP command. Several
threads already exist on the matter:
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01806.html
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-06-05 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 21:42 [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently) Laszlo Ersek
2015-06-05 21:47 ` Eric Blake [this message]
2015-06-05 21:53 ` Laszlo Ersek
2015-06-08 12:55 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55721905.2040307@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lersek@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).