From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0zT7-00016h-GU for qemu-devel@nongnu.org; Fri, 05 Jun 2015 17:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0zT3-00039Q-C6 for qemu-devel@nongnu.org; Fri, 05 Jun 2015 17:48:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0zT3-000396-6v for qemu-devel@nongnu.org; Fri, 05 Jun 2015 17:47:57 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1C382362090 for ; Fri, 5 Jun 2015 21:47:56 +0000 (UTC) Message-ID: <55721905.2040307@redhat.com> Date: Fri, 05 Jun 2015 15:47:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <557217CF.4090907@redhat.com> In-Reply-To: <557217CF.4090907@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NaDUNolhxxhJMCUu6KQFjUeFifRBE1iel" Subject: Re: [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , Markus Armbruster , libvir-list@redhat.com, qemu devel list This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NaDUNolhxxhJMCUu6KQFjUeFifRBE1iel Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/05/2015 03:42 PM, Laszlo Ersek wrote: > I found this qemu commit, ie. >=20 > commit 65207c59d99f2260c5f1d3b9c491146616a522aa > Author: Markus Armbruster > Date: Thu Mar 5 14:35:26 2015 +0100 >=20 > monitor: Drop broken, unused asynchronous command interface >=20 > with bisection. Unfortunately, the bisection was extremely painful, bec= ause between a working version and today's pull, part of the qemu history= was uncompileable. It was ultimately fixed with > Which tells me that it's not individual capabilities that are broken by= qemu 65207c59, but the entire libvirt capability retrieval. Apparently l= ibvirt is one user of that async monitor interface. (The message on commi= t 65207c59 itself mentions "qmp_capabilities".) Libvirt doesn't use async capabilities, so much as Markus accidentally broke the QMP protocol by completely ditching support for the "id" member that libvirt uses on every synchronous QMP command. Several threads already exist on the matter: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01806.html https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NaDUNolhxxhJMCUu6KQFjUeFifRBE1iel Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVchkFAAoJEKeha0olJ0NqzjkH/RA19xx0IaO8oSagW54THtvm 8f+s5HTVmM9gLNQHotwyG1rebfU1yE7LTgR9buF7dJUQekxTI2Hhm0l2qH4ZJ9d5 b8kooAQpm0MOGZS3Daq90Dbjw02N7RUYz2efKlPVqx7uiF3cq9BW6ThpFfkVsKiP oKSod95cAumdnL0ZcSVvViUTMKKGRcqGBuPzF8W1pt1OAIvfEnIp80lo4K43MrVB iPwLOxbt8DLjg3RQryjBZsO7f+8tmdgTuTzW0Os616U7Hvn4gq7KGv+5rOlY86rf uMpdV2J7Aq7NtR8vgX7lNu1RW8h8Tg7ZMEfauZvmZrHBJwNIbuFeRZAnt7+M+Mg= =9pXP -----END PGP SIGNATURE----- --NaDUNolhxxhJMCUu6KQFjUeFifRBE1iel--