From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1qCT-0001ml-HS for qemu-devel@nongnu.org; Mon, 08 Jun 2015 02:06:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1qCQ-0005M1-AV for qemu-devel@nongnu.org; Mon, 08 Jun 2015 02:06:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1qCQ-0005KB-4l for qemu-devel@nongnu.org; Mon, 08 Jun 2015 02:06:18 -0400 Message-ID: <557530D5.2050807@redhat.com> Date: Mon, 08 Jun 2015 14:06:13 +0800 From: Jason Wang MIME-Version: 1.0 References: <1433514749-19584-1-git-send-email-pagupta@redhat.com> In-Reply-To: <1433514749-19584-1-git-send-email-pagupta@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] net:Enable vhost with vhostforce, vhost options for guests without MSI-X support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pankaj Gupta , qemu-devel@nongnu.org Cc: aliguori@amazon.com, stefanha@redhat.com, mst@redhat.com On 06/05/2015 10:32 PM, Pankaj Gupta wrote: > We use vhostforce to enable vhost even if Guests don't have MSI-X support > and we fall back to QEMU virtio-net. This patch will enable vhost unconditionally > whenever we have vhostforce='ON' or vhost='ON'. > > Initially, I wanted to remove vhostforce completely as an additional argument. > But after discussing this in mailing list found that some programs are using vhostforce > and some vhost. So, we want to keep semantics of both the options. > > Signed-off-by: Pankaj Gupta > --- > net/tap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/tap.c b/net/tap.c > index d1ca314..4618359 100644 > --- a/net/tap.c > +++ b/net/tap.c > @@ -649,13 +649,13 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, > } > } > > - if (tap->has_vhost ? tap->vhost : > - vhostfdname || (tap->has_vhostforce && tap->vhostforce)) { > + if ((tap->has_vhost ? tap->vhost : > + vhostfdname) || tap->vhostforce) { > VhostNetOptions options; > > options.backend_type = VHOST_BACKEND_TYPE_KERNEL; > options.net_backend = &s->nc; > - options.force = tap->has_vhostforce && tap->vhostforce; > + options.force = true; > > if (tap->has_vhostfd || tap->has_vhostfds) { > vhostfd = monitor_fd_param(cur_mon, vhostfdname, &err); In this case, I believe there's no need to have vhost_net_query() and query_guest_notifiers() callbacks (and maybe more others).