From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1sFI-0005sA-Nm
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:17:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1sFD-0003Sb-Fi
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:17:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1sFD-0003S1-Aj
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:17:19 -0400
Message-ID: <55754F89.7010206@redhat.com>
Date: Mon, 08 Jun 2015 10:17:13 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <02aa01d09f9a$5bb198d0$1314ca70$@samsung.com>	<5571B3E6.1030606@redhat.com>
	<87sia2lixw.fsf@blackfin.pond.sub.org>
In-Reply-To: <87sia2lixw.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Do not fail if id field is present.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org



On 08/06/2015 10:10, Markus Armbruster wrote:
> > > +        } else if (!strcmp(arg_name, "id")) {
> > > +            /* Ignored, necessary for backwards compatibility */
> > >          } else {
> > >              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
> > >              return NULL;
> > > 
> >
> > Nope, this is not enough to fix virt-test.
> Really?  Details?

It really wants the id in the reply to match the id in the request.

Paolo