From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Do not fail if id field is present.
Date: Mon, 08 Jun 2015 10:24:31 +0200 [thread overview]
Message-ID: <5575513F.8010005@redhat.com> (raw)
In-Reply-To: <87wpzelj0d.fsf@blackfin.pond.sub.org>
On 08/06/2015 10:08, Markus Armbruster wrote:
> > Remember, Markus' patch was about removing asynchronous commands,
> > because _those_ commands were where "id" was mishandled (and if we DID
> > want asynch commands, it would be even MORE important that they handle
> > id corerctly). But he accidentally removed 2 lines (the strcmp to "id"
> > and a now stale FIXME comment about wanting to check for duplicate "id"s
> > being tracked across parallel async commands) when it should have only
> > removed one (the stale comment),
>
> Exactly.
Oh, then it does fix virt-test too.
Paolo
next prev parent reply other threads:[~2015-06-08 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:17 [Qemu-devel] [PATCH] Do not fail if id field is present Pavel Fedin
2015-06-05 14:32 ` Daniel P. Berrange
2015-06-05 22:10 ` Eric Blake
2015-06-08 8:08 ` Markus Armbruster
2015-06-08 8:24 ` Paolo Bonzini [this message]
2015-06-05 14:36 ` Paolo Bonzini
2015-06-08 8:10 ` Markus Armbruster
2015-06-08 8:17 ` Paolo Bonzini
2015-06-08 8:26 ` Wen Congyang
2015-06-05 15:43 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5575513F.8010005@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).