From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1sMJ-0001QR-82 for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:24:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1sMF-00087z-Qu for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:24:39 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:34706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1sMF-00087I-AR for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:24:35 -0400 Received: by wibut5 with SMTP id ut5so77512118wib.1 for ; Mon, 08 Jun 2015 01:24:33 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5575513F.8010005@redhat.com> Date: Mon, 08 Jun 2015 10:24:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <02aa01d09f9a$5bb198d0$1314ca70$@samsung.com> <20150605143247.GJ11483@redhat.com> <55721E38.6030402@redhat.com> <87wpzelj0d.fsf@blackfin.pond.sub.org> In-Reply-To: <87wpzelj0d.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Do not fail if id field is present. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Eric Blake Cc: Pavel Fedin , qemu-devel@nongnu.org On 08/06/2015 10:08, Markus Armbruster wrote: > > Remember, Markus' patch was about removing asynchronous commands, > > because _those_ commands were where "id" was mishandled (and if we DID > > want asynch commands, it would be even MORE important that they handle > > id corerctly). But he accidentally removed 2 lines (the strcmp to "id" > > and a now stale FIXME comment about wanting to check for duplicate "id"s > > being tracked across parallel async commands) when it should have only > > removed one (the stale comment), > > Exactly. Oh, then it does fix virt-test too. Paolo