From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34274)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z1tFG-0005Ra-Eo
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 05:21:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z1tFA-0006Uh-Uu
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 05:21:26 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:37667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z1tFA-0006N4-CM
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 05:21:20 -0400
Message-ID: <55755E77.8020805@huawei.com>
Date: Mon, 8 Jun 2015 17:20:55 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1433252721-19610-1-git-send-email-berrange@redhat.com>
	<1433252721-19610-6-git-send-email-berrange@redhat.com>
In-Reply-To: <1433252721-19610-6-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 05/10] crypto: add a gcrypt cipher
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Richard Henderson <rth@twiddle.net>

On 2015/6/2 21:45, Daniel P. Berrange wrote:
> +
> +void qcrypto_cipher_free(QCryptoCipher *cipher)
> +{
> +    gcry_cipher_hd_t handle = cipher->opaque;
> +    if (!cipher) {
> +        return;
> +    }

The check is too late. :(

> +    gcry_cipher_close(handle);
> +    g_free(cipher);
> +}

Regards,
-Gonglei