From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1uaL-0006SB-CA for qemu-devel@nongnu.org; Mon, 08 Jun 2015 06:47:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1uaH-0007FG-8K for qemu-devel@nongnu.org; Mon, 08 Jun 2015 06:47:17 -0400 Message-ID: <557572A6.7010109@redhat.com> Date: Mon, 08 Jun 2015 12:47:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433759662-25139-1-git-send-email-famz@redhat.com> <1433759662-25139-3-git-send-email-famz@redhat.com> In-Reply-To: <1433759662-25139-3-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add "detect-zeroes" option to drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , stefanha@redhat.com, Markus Armbruster , qemu-block@nongnu.org On 08/06/2015 12:34, Fam Zheng wrote: > - "unmap": whether the target sectors should be discarded where source has only > zeroes. (json-bool, optional, default true) > +- "detect-zeroes": if true, the source sectors that are zeroes will be written as > + sparse on target. (json-bool, optional, default true) all source sectors that are zeroes will be written using offloaded zero writes on the target; furthermore, the sectors on the target will be made sparse if possible if "unmap" is also true. Perhaps it's simpler to use the enum though. I'm not sure. Jeff? Paolo