From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1vTv-0000bO-CR for qemu-devel@nongnu.org; Mon, 08 Jun 2015 07:44:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1vTs-0005dg-Kk for qemu-devel@nongnu.org; Mon, 08 Jun 2015 07:44:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1vTs-0005dG-Fp for qemu-devel@nongnu.org; Mon, 08 Jun 2015 07:44:40 -0400 Message-ID: <55758012.7060007@redhat.com> Date: Mon, 08 Jun 2015 13:44:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150601141054.GA11304@redhat.com> <20150601141343.GH13155@redhat.com> <20150601153237.GE2120@HEDWIG.INI.CMU.EDU> <20150601174409-mutt-send-email-mst@redhat.com> <20150601180022.GI2120@HEDWIG.INI.CMU.EDU> <20150601203126.GK2120@HEDWIG.INI.CMU.EDU> <1433229074.1637.7.camel@nilsson.home.kraxel.org> <20150605160555.GH9951@HEDWIG.INI.CMU.EDU> <1433748105.5046.6.camel@redhat.com> <20150608114309-mutt-send-email-mst@redhat.com> <1433762362.5046.28.camel@redhat.com> In-Reply-To: <1433762362.5046.28.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] fw cfg files cross-version migration races List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , "Michael S. Tsirkin" Cc: "Gabriel L. Somlo" , lersek@redhat.com, qemu-devel@nongnu.org On 08/06/2015 13:19, Gerd Hoffmann wrote: >>> I would simply sort everything (and do it for new machine types only, > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> for backward compatibility reasons). Sorting user-provided blobs only >>> adds complexity for no reason. > >> Do we want this for all machine types, or only for new ones? I think it is not backwards compatible: sorting names changes the fw_cfg ids of the files, and hence the guest ABI. Paolo