From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1wAR-0003DP-B6
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:28:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1wAL-00065n-Cg
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:28:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39627)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1wAL-00065W-7r
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:28:33 -0400
Message-ID: <55758A6C.9070005@redhat.com>
Date: Mon, 08 Jun 2015 14:28:28 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150601153237.GE2120@HEDWIG.INI.CMU.EDU>
	<20150601174409-mutt-send-email-mst@redhat.com>
	<20150601180022.GI2120@HEDWIG.INI.CMU.EDU>
	<20150601203126.GK2120@HEDWIG.INI.CMU.EDU>
	<1433229074.1637.7.camel@nilsson.home.kraxel.org>
	<20150605160555.GH9951@HEDWIG.INI.CMU.EDU>
	<1433748105.5046.6.camel@redhat.com>
	<20150608114309-mutt-send-email-mst@redhat.com>
	<1433762362.5046.28.camel@redhat.com> <55758012.7060007@redhat.com>
	<20150608122355.GB32650@HEDWIG.INI.CMU.EDU>
In-Reply-To: <20150608122355.GB32650@HEDWIG.INI.CMU.EDU>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] fw cfg files cross-version migration races
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: qemu-devel@nongnu.org, lersek@redhat.com, Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>



On 08/06/2015 14:23, Gabriel L. Somlo wrote:
> I'm wonderingjust when exactly to start sorting items in fw_cfg ? 
> 
> Different machine types insert different blobs at various points
> during their initialization (and possibly on-demand during hot-plug
> events, I'm not 100% sure).

Hotplug may modify contents (I don't think it does), but it shouldn't
add files.

> So when exactly can we know that "we now have everything, it's time to
> start sorting" ?

There is a machine_ready callback.

> I'm also assuming this applies to named (file) entries only, and the
> unnamed entries (with "indices" in the "table" < FW_CFG_FILE_DIR) will
> not have to be sorted.

Yes.

Paolo