From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1xLP-0006gM-Hu for qemu-devel@nongnu.org; Mon, 08 Jun 2015 09:44:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1xLL-0007gv-TL for qemu-devel@nongnu.org; Mon, 08 Jun 2015 09:44:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1xLL-0007gq-Oq for qemu-devel@nongnu.org; Mon, 08 Jun 2015 09:43:59 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2E0DA19F267 for ; Mon, 8 Jun 2015 13:43:59 +0000 (UTC) Message-ID: <55759C1B.7000905@redhat.com> Date: Mon, 08 Jun 2015 15:43:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430133591-6197-1-git-send-email-ghammer@redhat.com> <1430133591-6197-5-git-send-email-ghammer@redhat.com> <556F2D51.2000203@redhat.com> <55759BB8.3010604@redhat.com> In-Reply-To: <55759BB8.3010604@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: imammedo@redhat.com, mst@redhat.com On 08/06/2015 15:42, Gal Hammer wrote: > On 03/06/2015 19:37, Paolo Bonzini wrote: >> >> Since Michael said he'd merge this version, there's just one thing I >> would change. You can access the region only one byte at a time, and >> let the memory core fix endianness here: > > I've applied the change offered below. Thanks. > > There are two unanswered questions: > > 1. You wrote that I should not use the memory_region_init_io() function. > Should I use memory_region_init_ram() instead? This is related to the uncached vs. cached memory discussion. Michael agreed that it's okay to do it this way. > 2. Is it possible to create a sysbus device using the "-device" command > line argument? I vaguely recall that it is not possible to do it and > that's the reason that I specifically add the device in the pc init. It's now possible, but it is somewhat complicated. I think it's simpler to initialize this unconditionally and hide it (via ACPI _STA) if the vmgenid is all zeros. Paolo