From: Gal Hammer <ghammer@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device
Date: Mon, 08 Jun 2015 16:52:10 +0300 [thread overview]
Message-ID: <55759E0A.3090102@redhat.com> (raw)
In-Reply-To: <55759C1B.7000905@redhat.com>
On 08/06/2015 16:43, Paolo Bonzini wrote:
>
>
> On 08/06/2015 15:42, Gal Hammer wrote:
>> On 03/06/2015 19:37, Paolo Bonzini wrote:
>>>
>>> Since Michael said he'd merge this version, there's just one thing I
>>> would change. You can access the region only one byte at a time, and
>>> let the memory core fix endianness here:
>>
>> I've applied the change offered below. Thanks.
>>
>> There are two unanswered questions:
>>
>> 1. You wrote that I should not use the memory_region_init_io() function.
>> Should I use memory_region_init_ram() instead?
>
> This is related to the uncached vs. cached memory discussion. Michael
> agreed that it's okay to do it this way.
OK. Nothing is changed for now.
>> 2. Is it possible to create a sysbus device using the "-device" command
>> line argument? I vaguely recall that it is not possible to do it and
>> that's the reason that I specifically add the device in the pc init.
>
> It's now possible, but it is somewhat complicated. I think it's simpler
> to initialize this unconditionally and hide it (via ACPI _STA) if the
> vmgenid is all zeros.
I didn't understand. I need the device to be a sysbus device so it won't
be found as an ISA or a PCI device by Windows. So I need to know what
ever or not it is possible to create a sysbus device using "-device". In
either way it won't be created if vmgenid is not given so no need to
hide it using _STA.
Gal.
> Paolo
>
next prev parent reply other threads:[~2015-06-08 13:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 11:19 [Qemu-devel] [PATCH V15 0/5] Virtual Machine Generation ID Gal Hammer
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description Gal Hammer
2015-04-27 13:42 ` Michael S. Tsirkin
2015-04-27 13:55 ` Michael S. Tsirkin
2015-04-28 14:20 ` Gal Hammer
2015-04-27 14:56 ` Eric Blake
2015-04-28 14:38 ` Gal Hammer
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 2/5] acpi: add a vm_generation_id_changed method Gal Hammer
2015-04-27 14:57 ` Eric Blake
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 3/5] aml: implement a 32-bit fixed memory range descriptor Gal Hammer
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device Gal Hammer
2015-04-27 13:38 ` Michael S. Tsirkin
2015-04-29 12:46 ` Gal Hammer
2015-04-27 14:59 ` Eric Blake
2015-05-28 10:25 ` Paolo Bonzini
2015-05-28 11:49 ` Michael S. Tsirkin
2015-05-28 11:59 ` Gal Hammer
2015-05-28 12:21 ` Michael S. Tsirkin
2015-05-28 13:00 ` Paolo Bonzini
2015-05-28 13:24 ` Michael S. Tsirkin
2015-05-28 13:35 ` Paolo Bonzini
2015-05-29 11:46 ` Igor Mammedov
2015-06-03 16:32 ` Michael S. Tsirkin
2015-06-03 16:37 ` Paolo Bonzini
2015-06-08 13:42 ` Gal Hammer
2015-06-08 13:43 ` Paolo Bonzini
2015-06-08 13:52 ` Gal Hammer [this message]
2015-06-08 13:55 ` Paolo Bonzini
2015-06-08 13:58 ` Daniel P. Berrange
2015-06-08 14:05 ` Gal Hammer
2015-06-08 15:01 ` Michael S. Tsirkin
2015-06-08 15:17 ` Paolo Bonzini
2015-06-08 15:22 ` Michael S. Tsirkin
2015-06-08 15:28 ` Gal Hammer
2015-06-08 15:32 ` Michael S. Tsirkin
2015-06-08 15:33 ` Paolo Bonzini
2015-06-08 15:41 ` Michael S. Tsirkin
2015-06-08 15:43 ` Paolo Bonzini
2015-06-08 14:00 ` Gal Hammer
2015-06-08 13:59 ` Paolo Bonzini
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device Gal Hammer
2015-04-27 15:01 ` Eric Blake
2015-04-27 16:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55759E0A.3090102@redhat.com \
--to=ghammer@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).