From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1y2h-0006r8-HZ for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1y2c-0002q0-Un for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:28:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1y2c-0002pg-QC for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:28:42 -0400 Message-ID: <5575A698.9000403@redhat.com> Date: Mon, 08 Jun 2015 08:28:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433753070-12632-1-git-send-email-armbru@redhat.com> <1433753070-12632-2-git-send-email-armbru@redhat.com> In-Reply-To: <1433753070-12632-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="08sIl3ogNoWXQ2mHAPBF9FLGSJ74CDmEO" Subject: Re: [Qemu-devel] [PATCH 1/1] monitor: Fix QMP ABI breakage around "id" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, fabio.fantoni@m2r.biz, p.fedin@samsung.com, dslutz@verizon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --08sIl3ogNoWXQ2mHAPBF9FLGSJ74CDmEO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/08/2015 02:44 AM, Markus Armbruster wrote: > Commit 65207c5 accidentally dropped a line of code we need along with > a comment that became wrong then. This made QMP reject "id": >=20 > {"execute": "system_reset", "id": "1"} > {"error": {"class": "GenericError", "desc": "QMP input object membe= r 'id' is unexpected"}} >=20 > Put the lost line right back, so QMP again accepts and returns "id", > as promised by the ABI: >=20 > {"execute": "system_reset", "id": "1"} > {"return": {}, "id": "1"} >=20 > Reported-by: Fabio Fantoni > Signed-off-by: Markus Armbruster > Signed-off-by: Don Slutz > Tested-by: Fabio Fantoni > Signed-off-by: Wen Congyang > Signed-off-by: Pavel Fedin > Tested-by: Eric Blake > Signed-off-by: Markus Armbruster Double S-o-b by Markus is odd. But it's already landed in master, I'm too late for fixing it :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --08sIl3ogNoWXQ2mHAPBF9FLGSJ74CDmEO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVdaaYAAoJEKeha0olJ0NqgusIAIuEPAv0D9HppC41kcRyR94Z 3uqRFyXqC53Zkyx96lJqcyf764Ed1cZLUbDPm3WvW4ZSNCU4Xs2cf6d6MegifeYS NcTk4ci58LYK7bcsSyx6GdZminwl6ka6I4Lso7DD2gq9lDyFYYweQq3YpjbT3W36 fQAaQbyxyySypjRYu15g6fGN/rhDm/9X7GbpnxiuEXtFPoaFVuvVWG22Upzgc+4z bD2MNXbGwAmrp/QID0sA++s9N60uyGT+z7EaPJC5FzCHxqVjlqVOXMSrFyil+CsQ C6hGT0LoR75i73ywiJyXpbqyW+KZ6dkHknD+xq/wlNvx0TYANKa69DkRt5Yu+Sg= =9tTf -----END PGP SIGNATURE----- --08sIl3ogNoWXQ2mHAPBF9FLGSJ74CDmEO--