From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1yP4-0003G4-LK for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:51:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1yOy-000292-RC for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:51:54 -0400 Message-ID: <5575ABF7.50306@redhat.com> Date: Mon, 08 Jun 2015 08:51:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433742974-20128-1-git-send-email-famz@redhat.com> <1433742974-20128-3-git-send-email-famz@redhat.com> In-Reply-To: <1433742974-20128-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tcOULrCn07alSjvgwJisl4oCjjw6lW8LO" Subject: Re: [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , qemu-stable@nongnu.org, Stefan Hajnoczi , pbonzini@redhat.com, jsnow@redhat.com, wangxiaolong@ucloud.cn This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tcOULrCn07alSjvgwJisl4oCjjw6lW8LO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/07/2015 11:56 PM, Fam Zheng wrote: > If specified as "true", it allows discarding on target sectors where so= urce is > not allocated. >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 8 ++++++-- > blockdev.c | 5 +++++ > hmp.c | 2 +- > include/block/block_int.h | 2 ++ > qapi/block-core.json | 8 +++++++- > qmp-commands.hx | 3 +++ > 6 files changed, 24 insertions(+), 4 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -973,6 +973,11 @@ > # @on-target-error: #optional the action to take on an error on the ta= rget, > # default 'report' (no limitations, since this appli= es to > # a different block device than @device). > +# @unmap: #optional Whether to try to unmap target sectors where sourc= e has > +# only zero. If true, and target unallocated sectors will read= as zero, > +# target image sectors will be unmapped; otherwise, zeroes wil= l be > +# written. Both will result in identical contents. > +# Default is true. (Since 2.4) > # Per the other thread on adding 'detect-zeroes', should we instead be using an enum here that describes one of several behaviors without an explosion into multiple knobs? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tcOULrCn07alSjvgwJisl4oCjjw6lW8LO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVdav3AAoJEKeha0olJ0NqizUIAKro/aDHast187ADcbbmAGCr bcc76A7WkjHvRM2pntZPNb0R9tsyoHKQimJbKUBL4VCCoHZDKUAmQViTBOhvqCNd 1KiihJea80FHO/rsilSLadQuTseS+HjtGEH/gC/uU4Xr/w+kQjVEgKjkkLI9A4vf 8+rj1jpU1xCJCunqgL53UEdLEyoD+pZQsgExSecrzgY6NhZx1cvJvslRdlTWSbwV LaY53wy3SGJeSjYWmIlo2zduFM+DAHQZsBjbeAlNi9KFUleyQsibOUUvQICpHCn0 +ouV2g7Dk6+uQk/p6aKIy8czhVGeZmZ3WUVdhtryAdxngLJazNKS/rH2s/NkP5Q= =qdYG -----END PGP SIGNATURE----- --tcOULrCn07alSjvgwJisl4oCjjw6lW8LO--