From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1ySE-0006Mz-Hm for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:55:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1yS8-0003f7-RF for qemu-devel@nongnu.org; Mon, 08 Jun 2015 10:55:10 -0400 Message-ID: <5575ACB9.4030503@redhat.com> Date: Mon, 08 Jun 2015 16:54:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433742974-20128-1-git-send-email-famz@redhat.com> <1433742974-20128-3-git-send-email-famz@redhat.com> <5575ABF7.50306@redhat.com> In-Reply-To: <5575ABF7.50306@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , qemu-stable@nongnu.org, Stefan Hajnoczi , jsnow@redhat.com, wangxiaolong@ucloud.cn On 08/06/2015 16:51, Eric Blake wrote: >> > +# @unmap: #optional Whether to try to unmap target sectors where source has >> > +# only zero. If true, and target unallocated sectors will read as zero, >> > +# target image sectors will be unmapped; otherwise, zeroes will be >> > +# written. Both will result in identical contents. >> > +# Default is true. (Since 2.4) >> > # > Per the other thread on adding 'detect-zeroes', should we instead be > using an enum here that describes one of several behaviors without an > explosion into multiple knobs? See my answer there. :) Paolo