From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z1yts-0004dI-RX
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 11:23:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z1ytm-0006RU-F4
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 11:23:44 -0400
Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:35080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z1ytm-0006RH-27
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 11:23:38 -0400
Received: by wiga1 with SMTP id a1so90395528wig.0
	for <qemu-devel@nongnu.org>; Mon, 08 Jun 2015 08:23:37 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5575B377.5030701@redhat.com>
Date: Mon, 08 Jun 2015 17:23:35 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1433776757-61958-1-git-send-email-imammedo@redhat.com>
	<1433776757-61958-2-git-send-email-imammedo@redhat.com>
In-Reply-To: <1433776757-61958-2-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 1/6] memory: get rid of
	memory_region_destructor_ram_from_ptr()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com



On 08/06/2015 17:19, Igor Mammedov wrote:
> -    qemu_mutex_lock_ramlist();
> -    QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
> -        if (addr == block->offset) {
> -            QLIST_REMOVE_RCU(block, next);
> -            ram_list.mru_block = NULL;
> -            /* Write list before version */
> -            smp_wmb();
> -            ram_list.version++;
> -            g_free_rcu(block, rcu);

qemu_ram_free here does:

            call_rcu(block, reclaim_ramblock, rcu);

which is different.

Paolo

> -            break;
> -        }
> -    }
> -    qemu_mutex_unlock_ramlist();