From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1zc6-0003aK-D3
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:09:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1zc1-0005yw-J8
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:09:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59020)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z1zc1-0005ym-Es
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:09:21 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 3442FBACDB
	for <qemu-devel@nongnu.org>; Mon,  8 Jun 2015 16:09:21 +0000 (UTC)
Message-ID: <5575BE2D.7060603@redhat.com>
Date: Mon, 08 Jun 2015 18:09:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1433776757-61958-1-git-send-email-imammedo@redhat.com>	<1433776757-61958-2-git-send-email-imammedo@redhat.com>	<5575B377.5030701@redhat.com>
	<20150608180830.3a889453@nial.brq.redhat.com>
In-Reply-To: <20150608180830.3a889453@nial.brq.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 1/6] memory: get rid of
	memory_region_destructor_ram_from_ptr()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com



On 08/06/2015 18:08, Igor Mammedov wrote:
> On Mon, 08 Jun 2015 17:23:35 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>>
>>
>> On 08/06/2015 17:19, Igor Mammedov wrote:
>>> -    qemu_mutex_lock_ramlist();
>>> -    QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
>>> -        if (addr == block->offset) {
>>> -            QLIST_REMOVE_RCU(block, next);
>>> -            ram_list.mru_block = NULL;
>>> -            /* Write list before version */
>>> -            smp_wmb();
>>> -            ram_list.version++;
>>> -            g_free_rcu(block, rcu);
>>
>> qemu_ram_free here does:
>>
>>             call_rcu(block, reclaim_ramblock, rcu);
>>
>> which is different.
> 
> 
> qemu_ram_free() calls reclaim_ramblock() which does:
> 
>   if (!(block->flags & RAM_PREALLOC))
>       free_host_memory()
> 
>   g_free(block)
> 
> while
>   g_free_rcu(block, rcu) results -> g_free(block)
> 
> and for memory_region_init_ram_ptr() we set RAM_PREALLOC
> so qemu_ram_free() degrades to g_free(block).

Please put this in the commit message. :)

Paolo