From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z22ph-0002AW-Vl for qemu-devel@nongnu.org; Mon, 08 Jun 2015 15:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z22pd-00079F-Uf for qemu-devel@nongnu.org; Mon, 08 Jun 2015 15:35:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z22pd-000796-PX for qemu-devel@nongnu.org; Mon, 08 Jun 2015 15:35:37 -0400 Message-ID: <5575EE83.1050503@redhat.com> Date: Mon, 08 Jun 2015 13:35:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433789877-6950-1-git-send-email-armbru@redhat.com> <1433789877-6950-4-git-send-email-armbru@redhat.com> In-Reply-To: <1433789877-6950-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9amcwJ98pokdVSAPi3OGS8JAPChmLcbwL" Subject: Re: [Qemu-devel] [PATCH 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, afaerber@suse.de, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9amcwJ98pokdVSAPi3OGS8JAPChmLcbwL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/08/2015 12:57 PM, Markus Armbruster wrote: > Reproducer: >=20 > $ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device vir= tio-rng-pci -device virtio-rng-device,bus=3Dvirtio-bus > qemu-system-x86_64: -device virtio-rng-device,bus=3Dvirtio-bus: Bus= 'virtio-bus' is full > qemu-system-x86_64: -device virtio-rng-device,bus=3Dvirtio-bus: Bus= 'virtio-bus' is full > qemu-system-x86_64: -device virtio-rng-device,bus=3Dvirtio-bus: Bus= 'virtio-bus' not found >=20 > qbus_find_recursive() reports the "is full" error itself, and leaves > reporting "not found" to its caller. The result is confusion. Write > it a function contract that permits leaving all error reporting to the > caller, and implement it. Update callers to detect and report "is > full". >=20 > Screwed up when commit 1395af6 added the max_dev limit and the "is > full" error condition to enforce it. >=20 > Signed-off-by: Markus Armbruster > --- > qdev-monitor.c | 62 ++++++++++++++++++++++++++++++++++++--------------= -------- > 1 file changed, 39 insertions(+), 23 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9amcwJ98pokdVSAPi3OGS8JAPChmLcbwL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVde6DAAoJEKeha0olJ0NqCVMH/Ali6gRY+NW7iZm1lscGcwuN GRsYJQ7EbCFwX4JgDlkOtARwNwQIqibKowdJtYgS4wdb3uOPnbxGtUq7r+mxTMgE S318ZD4e82TnQnY6xQ7IApQZS4WKOCI4FEvukHOkyF4kdc18BE0eZOeZlcZV3IzT ZAMbsqG9IaRgD5dTf8sa5Tn7sdKR9rMfBmmP6xY5OpqU/w4SQJOg6mRHlcK2Bvb1 3TUGJUnKBZXaYE0yOQNCkNzcz/VMjJWCOuQiTptgkbiOBrfg28jfFJPefeBsi9Cf YLO09DdVk18dJgEFco1dBmImfV0QdMESRQMTGlOXkTgfA6JJD79W2MwBgVHpnMY= =oT+0 -----END PGP SIGNATURE----- --9amcwJ98pokdVSAPi3OGS8JAPChmLcbwL--