From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z24NW-0007sp-FG for qemu-devel@nongnu.org; Mon, 08 Jun 2015 17:14:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z24NV-00033y-6G for qemu-devel@nongnu.org; Mon, 08 Jun 2015 17:14:42 -0400 Message-ID: <557605B6.5070707@redhat.com> Date: Mon, 08 Jun 2015 15:14:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433796555-5608-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1433796555-5608-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2tcAFPXMmDVXn4nK8gb1glvcQK4HQ30xM" Subject: Re: [Qemu-devel] [PATCH] block: record new size in bdrv_dirty_bitmap_truncate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2tcAFPXMmDVXn4nK8gb1glvcQK4HQ30xM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/08/2015 02:49 PM, John Snow wrote: > ce1ffea8 neglected to update the BdrvDirtyBitmap structure > itself for internal consistency. It's currently not an issue, > but for migration and persistence series this will cause headaches. >=20 > Signed-off-by: John Snow > --- > block.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/block.c b/block.c > index 2b9ceae..2786e47 100644 > --- a/block.c > +++ b/block.c > @@ -3224,6 +3224,7 @@ static void bdrv_dirty_bitmap_truncate(BlockDrive= rState *bs) > continue; > } > hbitmap_truncate(bitmap->bitmap, size); > + bitmap->size =3D size; > } > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2tcAFPXMmDVXn4nK8gb1glvcQK4HQ30xM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVdgW2AAoJEKeha0olJ0NqQYIH/jeaSOazIaB7yed+Z7dl4jnb hPfvJpcEpRKe9Y/cP5mbjJiev+D1e57MamPoF03OctRTYD8BdrB59378lAsxticB rq2u6QkISVySnoGwJpg2r9J4IWm8mOtwOtGxc6DgBV2dJFUxuvRE6M78hMvuVy7h Sc5dnSdgIKT9QC06ohrtHsFZ5Itjj/RsBQj017U5ih8Ug09z2dSrlk8pZqg5FiGl hO5A63hax/CqOYNgUY+id8hWAI0kPK9eeyXckq0Th058A/6B55WRlZ+rCe12/8de gsRWC5YxCVCXeEmH4dZaaAJMMxBm7DHgFMHO5z7eoxTJ3TnBufrpD3b7dlrr0NQ= =4Sqy -----END PGP SIGNATURE----- --2tcAFPXMmDVXn4nK8gb1glvcQK4HQ30xM--