From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2HBZ-0005Br-Ay for qemu-devel@nongnu.org; Tue, 09 Jun 2015 06:55:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2HB9-00021r-Ps for qemu-devel@nongnu.org; Tue, 09 Jun 2015 06:55:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2HB9-00021O-GM for qemu-devel@nongnu.org; Tue, 09 Jun 2015 06:54:47 -0400 Message-ID: <5576C5F5.10401@redhat.com> Date: Tue, 09 Jun 2015 04:54:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433789877-6950-1-git-send-email-armbru@redhat.com> <1433789877-6950-8-git-send-email-armbru@redhat.com> <5575F534.5020004@redhat.com> <87wpzdxvdh.fsf@blackfin.pond.sub.org> In-Reply-To: <87wpzdxvdh.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SWHoM1fHdHBoKuE23bqwxLiAbinWLRD8O" Subject: Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: pbonzini@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SWHoM1fHdHBoKuE23bqwxLiAbinWLRD8O Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/09/2015 12:12 AM, Markus Armbruster wrote: >> >>> if (!object_dynamic_cast(OBJECT(bus), dc->bus_type)) { >>> - qerror_report(ERROR_CLASS_GENERIC_ERROR, >>> - "Device '%s' can't go on a %s bus", >>> - driver, object_get_typename(OBJECT(bus)));= >>> + error_setg(errp, "Device '%s' can't go on a %s bus", >>> + driver, object_get_typename(OBJECT(bus))); >> >> Pre-existing - "a '%s' bus" or "an %s bus" might look a bit nicer than= >> "a %s bus" for some bus names (depends on the initial sound during >> pronunciation). Certainly a nightmare for translation rules to other >> languages that don't follow English rules on indefinite article usage.= >=20 > For a real nightmare, try following every other language's rules[*]. > Not following English rules will feel like a lullaby after that. >=20 >> Maybe some word-smithing can avoid the indefinite article altogether? >=20 > Do you think "Device '%s' can't go on %s bus" would be an improvement? Yes, I think that works. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SWHoM1fHdHBoKuE23bqwxLiAbinWLRD8O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVdsX1AAoJEKeha0olJ0NqDEIIAJvNmZMi5aYZJYYA0GQ/D0cd IXXjs/yCgUCkrjhuycrJ5bUv99ygfi42RvsgU5eUSsWaXQnxVy1uxmvKK+Ixrghf S1XhJddd19+Ys2i3XaF/FtMd4Jz5lnnevOtyWnNQL/Gw4e3ehx6cZK3HldDIJPkz FJ8m/kC2UxBiUYX8bDIX1E4eQBzeJMBtAEZJfgPGYyfSg1nduYnio4+7WKrDWvoG bgsL5S3yKFkYcLckPBE/HZWvwuhM7tV+hE4DVXqqTzmwu345uBcHmg+OerdfUQEo fi1d9T1vSWnhlwtf93+6kLMUZ1SQi/8Ey7/0UztZhT5E6zwN9WZG1/osAfWybCs= =fbNb -----END PGP SIGNATURE----- --SWHoM1fHdHBoKuE23bqwxLiAbinWLRD8O--