From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z2Hkh-0003wR-5O
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 07:31:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z2Hkc-00078J-8B
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 07:31:31 -0400
Message-ID: <5576CD07.6030302@huawei.com>
Date: Tue, 9 Jun 2015 19:24:55 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1431477807-12220-1-git-send-email-arei.gonglei@huawei.com>
	<555AEA20.3090501@huawei.com> <556C0B7A.3070601@huawei.com>
	<20150601122437-mutt-send-email-mst@redhat.com>
	<556C429F.3070802@redhat.com> <5576428A.4030603@huawei.com>
	<5576C74D.1050906@msgid.tls.msk.ru>
In-Reply-To: <5576C74D.1050906@msgid.tls.msk.ru>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] pci/isa: QOMify
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org, peter.huangpeng@huawei.com

On 2015/6/9 19:00, Michael Tokarev wrote:
> 09.06.2015 04:34, Gonglei wrote:
>> /mjt, what's your opinion? Thanks
> 
> Somehow I thought it is a single patch, and tried to find
> it @patchwork.  But it is a series of 6 patches (which I
> deleted from my inbox due to routine cleanup procedure).
> 
It's okay.
I can resend this series to qemu-trivial adding some acks tag.

>> Gonglei (6):
>>   pci-assign: QOMify
>>   piix: piix3 QOMify
>>   piix4: QOMify
>>   wdt_i6300esb: QOMify
>>   xen_pt: QOMify
>>   vt82c686: QOMify
> 
> Do we care about pci-assign?
> Maybe it's better to drop this code completely instead of
> fixing it?
> 
IIRC, supporting vfio needs the host kernel is above 3.10,
but this condition is harsh. On the other hand, pci-assign is
simple to use, for testing purpose.

> Other than that, I think it's okay to apply this series
> to -trivial.
> 
Thanks.

Regards,
-Gonglei