From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z2OOu-00032S-Bj
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 14:37:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z2OOr-0000SC-4t
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 14:37:28 -0400
Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:34210)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z2OOq-0000Re-Tj
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 14:37:25 -0400
Received: by pdbki1 with SMTP id ki1so20056634pdb.1
	for <qemu-devel@nongnu.org>; Tue, 09 Jun 2015 11:37:23 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <55772B9F.6040300@twiddle.net>
Date: Tue, 09 Jun 2015 11:08:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1433351328-23326-1-git-send-email-pbonzini@redhat.com>	<1433351328-23326-9-git-send-email-pbonzini@redhat.com>	<CAEgOgz69DOJ0P3o9M1TYk-SyMJMiF1374p8my_iPNQ9fs+cLkw@mail.gmail.com>
	<55700630.7090006@redhat.com>
In-Reply-To: <55700630.7090006@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style
 MMIO accessors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Laszlo Ersek <lersek@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On 06/04/2015 01:02 AM, Paolo Bonzini wrote:
> 
> 
> On 04/06/2015 08:19, Peter Crosthwaite wrote:
>> On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> This is a required step to implement read_with_attrs and write_with_attrs.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>  hw/block/pflash_cfi01.c | 96 ++++++-------------------------------------------
>>
>> Nice stats.
>>
>>>  1 file changed, 10 insertions(+), 86 deletions(-)
>>>
>>> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
>>> index 7507a15..0b3667a 100644
>>> --- a/hw/block/pflash_cfi01.c
>>> +++ b/hw/block/pflash_cfi01.c
>>> @@ -650,101 +650,25 @@ static void pflash_write(pflash_t *pfl, hwaddr offset,
>>>  }
>>>
>>>
>>> -static uint32_t pflash_readb_be(void *opaque, hwaddr addr)
>>> -{
>>> -    return pflash_read(opaque, addr, 1, 1);
>>> -}
>>> -
>>> -static uint32_t pflash_readb_le(void *opaque, hwaddr addr)
>>> -{
>>> -    return pflash_read(opaque, addr, 1, 0);
>>> -}
>>> -
>>> -static uint32_t pflash_readw_be(void *opaque, hwaddr addr)
>>> +static uint64_t pflash_mem_read(void *opaque, hwaddr addr, unsigned len)
>>>  {
>>>      pflash_t *pfl = opaque;
>>> +    bool be = !!(pfl->features & (1 << PFLASH_BE));
>>
>> !!() not needed. Otherwise
> 
> I don't like magic bool-ification...

I don't like !! just as much.  If you don't like implicit conversion, then use
!= 0.

> Is there a coding style item that
> forbids this idiom in bool assignments?

No.  Indeed, nothing in coding style about bool at all.


r~