From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2ftt-0002Nm-Ui for qemu-devel@nongnu.org; Wed, 10 Jun 2015 09:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2fto-0003xv-Cd for qemu-devel@nongnu.org; Wed, 10 Jun 2015 09:18:37 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:35740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2fto-0003ut-12 for qemu-devel@nongnu.org; Wed, 10 Jun 2015 09:18:32 -0400 Received: by pdbnf5 with SMTP id nf5so37953676pdb.2 for ; Wed, 10 Jun 2015 06:18:30 -0700 (PDT) Message-ID: <55783923.2000203@linaro.org> Date: Wed, 10 Jun 2015 21:18:27 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1430321049-11859-1-git-send-email-shannon.zhao@linaro.org> In-Reply-To: <1430321049-11859-1-git-send-email-shannon.zhao@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, zhaoshenglong@huawei.com, mst@redhat.com Ping? Have these patches been missed? On 2015/4/29 23:24, Shannon Zhao wrote: > The private qdev properties of virtio devices are only used by > themselves. As Peter suggested and like what virtio-blk has done, we > should move the private qdev properties into devices and don't expose > them to avoid wrongly use. > > This patchset is based on following patchset which moves host features > to backends. > http://lists.gnu.org/archive/html/qemu-devel/2015-04/msg03785.html > > Shannon Zhao (7): > virtio-net: move qdev properties into virtio-net.c > virtio-net.h: Remove unsed DEFINE_VIRTIO_NET_PROPERTIES > virtio-scsi: move qdev properties into virtio-scsi.c > virtio-rng: move qdev properties into virtio-rng.c > virtio-serial-bus: move qdev properties into virtio-serial-bus.c > virtio-9p-device: move qdev properties into virtio-9p-device.c > vhost-scsi: move qdev properties into vhost-scsi.c > > hw/9pfs/virtio-9p-device.c | 3 ++- > hw/9pfs/virtio-9p.h | 4 ---- > hw/char/virtio-serial-bus.c | 3 ++- > hw/net/virtio-net.c | 42 ++++++++++++++++++++++++++++++++++++++- > hw/scsi/vhost-scsi.c | 9 ++++++++- > hw/scsi/virtio-scsi.c | 13 ++++++++++-- > hw/virtio/virtio-rng.c | 8 +++++++- > include/hw/virtio/vhost-scsi.h | 9 --------- > include/hw/virtio/virtio-net.h | 31 +---------------------------- > include/hw/virtio/virtio-rng.h | 10 ---------- > include/hw/virtio/virtio-scsi.h | 13 ------------ > include/hw/virtio/virtio-serial.h | 3 --- > 12 files changed, 72 insertions(+), 76 deletions(-) > -- Shannon