From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2nYw-0002Nl-Ot for qemu-devel@nongnu.org; Wed, 10 Jun 2015 17:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2nYv-00046J-QL for qemu-devel@nongnu.org; Wed, 10 Jun 2015 17:29:30 -0400 Message-ID: <5578AC2D.3060604@redhat.com> Date: Wed, 10 Jun 2015 15:29:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433944027-28533-1-git-send-email-kwolf@redhat.com> <1433944027-28533-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1433944027-28533-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HIetuCWaNet7HBPmXbQpmGfIaEJ1C2iPs" Subject: Re: [Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, berto@igalia.com, armbru@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HIetuCWaNet7HBPmXbQpmGfIaEJ1C2iPs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/10/2015 07:46 AM, Kevin Wolf wrote: > In the block layer functions that determine options for a child block > device, it's a common pattern to either copy options from the parent's > options or to set a default string if the option isn't explicitly set > yet for the child. Provide convenience functions so that it becomes a > one-liner for each option. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > include/qapi/qmp/qdict.h | 3 +++ > qobject/qdict.c | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HIetuCWaNet7HBPmXbQpmGfIaEJ1C2iPs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVeKwtAAoJEKeha0olJ0NqprsH/3GP0NmzbGqqjSRQVxAd3gyZ LJjTG5kOWNkxXvG+7o29Nd/w5kOeMfQ1hKZRZoGwdTFH+c92mjD5Wh6G9BDHztoR aeILj1BMsfYfINzqJDVauKUGKLWIEYJNcJg2l1lEVLEH5YkYGT+iC99fHEZLOl7B h1WR35sy1hb6VVxisdGMp/Y8oKGW07BWmA51IA0p+Qi9eggnUsfR8FOTxBc27/dS YgwZwyHtLoWYffoAEtWY1iyZLocfkS4lOcZJc5zHU54vr4LybBtPChLhBuxy8bjp gS3ZOtiJUP1aTI/K4gnsaDabI42hKs5M74ZEVniFPgxwB5qVOzkn90dSPjjwGZs= =zm97 -----END PGP SIGNATURE----- --HIetuCWaNet7HBPmXbQpmGfIaEJ1C2iPs--