From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2nlQ-0007Zr-Sm for qemu-devel@nongnu.org; Wed, 10 Jun 2015 17:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2nlQ-0002GU-4L for qemu-devel@nongnu.org; Wed, 10 Jun 2015 17:42:24 -0400 Message-ID: <5578AF39.9040800@redhat.com> Date: Wed, 10 Jun 2015 15:42:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433944027-28533-1-git-send-email-kwolf@redhat.com> <1433944027-28533-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1433944027-28533-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LuApndMXBwESG1GKdN4sdbhPrtrVNOnmB" Subject: Re: [Qemu-devel] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, berto@igalia.com, armbru@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LuApndMXBwESG1GKdN4sdbhPrtrVNOnmB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/10/2015 07:47 AM, Kevin Wolf wrote: > Instead of manually parsing options and then deleting them from the > options QDict, just use QemuOpts like most other places that deal with > block device options. >=20 > More options will be added there and then QemuOpts is a lot more > managable than open-coding everything. s/managable/manageable/ >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 39 ++++++++++++++++++++++++++++++++++----- > 1 file changed, 34 insertions(+), 5 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LuApndMXBwESG1GKdN4sdbhPrtrVNOnmB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVeK85AAoJEKeha0olJ0NqPX8IAJA/OTlR8olnJQvSo2RT8jnB AuhmKIsu2cWdbfjMs7zcPjqEswJp0/64efTIg07eEx6AjU5GPTt+uSOOVBljLop1 JxJS9bRdJ4xJNWm76HzXaELA85AbHq6H+aCxv2MkR/9Io9x+K3ilgVZcPnLN/SCR oW4bEZoOZDwYOoES5dEXWPh3AWcQSXf1ijH45+ELEzG0Au1+3Kf2jIR7tr0XGuI8 Nkq6esI2sAq8LqMK0g8tFtZ0MVO6yiJF8Vhv5kStsrs6Hwh/dlRM/S15T8Sx1FWl cC9y9hHnZueT7epQZJn41IjovIIwdI5kY8voweFv1l7OYMWF5qwiS+zeJKcjXzQ= =7/iX -----END PGP SIGNATURE----- --LuApndMXBwESG1GKdN4sdbhPrtrVNOnmB--