From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2pOc-0002JD-9q for qemu-devel@nongnu.org; Wed, 10 Jun 2015 19:26:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2pOb-0003sn-3W for qemu-devel@nongnu.org; Wed, 10 Jun 2015 19:26:58 -0400 Message-ID: <5578C7BA.50503@redhat.com> Date: Wed, 10 Jun 2015 17:26:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433944027-28533-1-git-send-email-kwolf@redhat.com> <1433944027-28533-12-git-send-email-kwolf@redhat.com> In-Reply-To: <1433944027-28533-12-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Gw3fHc6MnIbSmBHEo5PcKlTSmdSPVk1mC" Subject: Re: [Qemu-devel] [PATCH v2 11/13] block: Add list of children to BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, berto@igalia.com, armbru@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gw3fHc6MnIbSmBHEo5PcKlTSmdSPVk1mC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/10/2015 07:47 AM, Kevin Wolf wrote: > This allows iterating over all children of a given BDS, not only > including bs->file and bs->backing_hd, but also driver-specific > ones like VMDK extents or Quorum children. >=20 > For bdrv_swap(), the list of children of the swapped BDS stays at that > BDS (because that's where the pointers stay as well). The list head > moves and pointers to it must be fixed up therefore. >=20 > The list of children in the parent of the swapped BDS is not affected b= y > the swap. The contents of the BDS objects is swapped, so the existing > pointer in the parent automatically points to the newly swapped in BDS.= >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 37 +++++++++++++++++++++++++++++++++++++ > include/block/block_int.h | 8 ++++++++ > 2 files changed, 45 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Gw3fHc6MnIbSmBHEo5PcKlTSmdSPVk1mC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVeMe6AAoJEKeha0olJ0Nq9N4H/1wSD8/rMkLONHqdLUO37hcm QI/XfMnLIPqp8UTgvcOTbopLDEcz1Fv1Dd9V+D5h9Jv2m1DbAMj8iErLO0hzTGvT CQvOSMa4jae5QT5hdjbT3VUcX16zqU5Fv270MTt6JJcwd0EPLmT6f/xVWrcGMtBm XWPi1tva87wgyzMryPyg6EJPsWv4OYbJmb04+GzOR3/CLqqu0NYxuvS4GF9G10W5 hrtBYAh/5Am8gxfRdDO7V1gWpF8Q3fRL+Gq6lb8BGlRAqFWGAvI5hdDGK2fKnYKH TGcelDcyd35wbtq6/taPSs8qmwr1ROBKpEkk7u/O2xK8/9FgWYXCUJrUkx29Xrs= =HDSz -----END PGP SIGNATURE----- --Gw3fHc6MnIbSmBHEo5PcKlTSmdSPVk1mC--