From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z2vRd-0008OA-3b
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 01:54:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z2vRZ-0005Hw-4R
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 01:54:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52319)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z2vRY-0005Hq-UK
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 01:54:25 -0400
Message-ID: <5579228E.1040705@redhat.com>
Date: Thu, 11 Jun 2015 13:54:22 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1433943783-20125-1-git-send-email-thibaut.collet@6wind.com>	<1433943783-20125-3-git-send-email-thibaut.collet@6wind.com>	<20150610173321-mutt-send-email-mst@redhat.com>	<CABUUfwN4sx6u7PiJ_PPKPqvkw1+JHM5x7=qGYeucx7G36eFdog@mail.gmail.com>	<20150610180013-mutt-send-email-mst@redhat.com>	<CABUUfwOMHZivKNyeGafdjdRkYBWHfa6TB5rfOinDAFz+_TwEkA@mail.gmail.com>	<55791F29.6060000@redhat.com>
	<CABUUfwOAG2R_pYRSvr4K=5cg4Z+56PpVFOan-3hKEzD7=GcvPA@mail.gmail.com>
In-Reply-To: <CABUUfwOAG2R_pYRSvr4K=5cg4Z+56PpVFOan-3hKEzD7=GcvPA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for
	legacy guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thibaut Collet <thibaut.collet@6wind.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>



On 06/11/2015 01:49 PM, Thibaut Collet wrote:
> > Yes, but still need a mechanism to notify the backend of migration
> > completion from qemu side if GUEST_ANNOUNCE is not negotiated.
>
> backend is aware of a connection with the guest (with the feature
> negociation) and can send a rarp. This rarp will be always sent by the
> backend when a VM is launched (first start or live migration
> completion) if the GUEST_ANOUNCE is not supported.
> In this case the issue is solved without done everything by QEMU.

The issue is during migration guest network is still active. So sending
rarp too early in the destination (e.g during VM is launched) may
confuse the switch.  We want it to be sent exactly when the migration is
completed in destination.

> If sending a rarp message on the start of te VM is not accceptable, we
> must provide a mechanism similar of the one I have implemented. The
> message content can be empty as the backend is able to create the rarp
> message.

Yes.