From: Eric Blake <eblake@redhat.com>
To: Christoph Hellwig <hch@lst.de>, qemu-block@nongnu.org
Cc: Keith Busch <keith.busch@intel.com>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes
Date: Thu, 11 Jun 2015 06:26:40 -0600 [thread overview]
Message-ID: <55797E80.9050608@redhat.com> (raw)
In-Reply-To: <1434016899-18643-1-git-send-email-hch@lst.de>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On 06/11/2015 04:01 AM, Christoph Hellwig wrote:
> The first patch ensures that flush actually flushes data so that
> data integrity is preserved, the second fixe up WCE reporting.
>
Cover letter is missing a diffstat and also a 0/2 designation, which
makes it harder to see up front what it touches (git
format-patch/send-email --cover-letter is your friend). Also, you
forgot to cc: the maintainer and the primary qemu-devel list (qemu-devel
should be included in ALL patches, and scripts/get_maintainer.pl will
help you learn maintainers). I've added them in cc.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next parent reply other threads:[~2015-06-11 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434016899-18643-1-git-send-email-hch@lst.de>
2015-06-11 12:26 ` Eric Blake [this message]
2015-06-17 11:59 ` [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes Christoph Hellwig
2015-06-17 12:24 ` Kevin Wolf
2015-07-04 4:58 ` Christoph Hellwig
2015-07-08 10:05 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55797E80.9050608@redhat.com \
--to=eblake@redhat.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).