From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z31ZS-0006ZG-QM for qemu-devel@nongnu.org; Thu, 11 Jun 2015 08:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z31ZQ-0004Dt-R7 for qemu-devel@nongnu.org; Thu, 11 Jun 2015 08:26:58 -0400 Message-ID: <55797E80.9050608@redhat.com> Date: Thu, 11 Jun 2015 06:26:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434016899-18643-1-git-send-email-hch@lst.de> In-Reply-To: <1434016899-18643-1-git-send-email-hch@lst.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UalnqfC8qHxu3Wv7GTIov1t1GKvBAci9j" Subject: Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig , qemu-block@nongnu.org Cc: Keith Busch , "kwolf@redhat.com" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UalnqfC8qHxu3Wv7GTIov1t1GKvBAci9j Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/11/2015 04:01 AM, Christoph Hellwig wrote: > The first patch ensures that flush actually flushes data so that > data integrity is preserved, the second fixe up WCE reporting. >=20 Cover letter is missing a diffstat and also a 0/2 designation, which makes it harder to see up front what it touches (git format-patch/send-email --cover-letter is your friend). Also, you forgot to cc: the maintainer and the primary qemu-devel list (qemu-devel should be included in ALL patches, and scripts/get_maintainer.pl will help you learn maintainers). I've added them in cc. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UalnqfC8qHxu3Wv7GTIov1t1GKvBAci9j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVeX6AAAoJEKeha0olJ0Nqj2QH/iHO3reYdjBVW1Fa2iSxxzfi Mkr3dBET7UI9BasWZNWQ2SqRUIGapSWIclSwGptzKiOA68c+85ZBA/63yYUaRIcS mXGKohI/5sf7WiRpEtWV+Js3nLpKhf3jtnzc5lJnJY4kcfeWZZL1k2lxFT8T1Nj3 HKNKiXSara9V4auRJ/jEj5FTECV26Dmo/54HXNUwi3t+kbarwvCuQAPKjwuL1QL9 vrw5rWkOZyyxcTu4ugQnJRhVsx7di55ZS1pK+3yoIHsQ9C8fvVWfA36CM3CrS8vG uqIhNMz6FKXC9uk7QHbhCMkc06XPT8Ga53NCarh5xOgSYHAz/XtMxbKL6aPKCos= =8x0r -----END PGP SIGNATURE----- --UalnqfC8qHxu3Wv7GTIov1t1GKvBAci9j--