From: John Snow <jsnow@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Makefile: Generate tag files under $SRC_PATH
Date: Thu, 11 Jun 2015 14:01:34 -0400 [thread overview]
Message-ID: <5579CCFE.5060200@redhat.com> (raw)
In-Reply-To: <20150611084124.GC22459@ad.nay.redhat.com>
On 06/11/2015 04:41 AM, Fam Zheng wrote:
> On Fri, 05/22 13:35, Fam Zheng wrote:
>
> Ping :)
>
> Fam
>
>>
>>
>> Fam Zheng (2):
>> Makefile: Fix "make cscope TAGS"
>> Makefile: Add "make ctags"
>>
>> Makefile | 20 +++++++++++++++-----
>> 1 file changed, 15 insertions(+), 5 deletions(-)
>>
>> --
>> 2.4.1
>>
>>
>
Looks good to me -- this has long been a major annoyance of mine when I
want to review code (and zip around) without trying to configure it first.
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2015-06-11 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 5:35 [Qemu-devel] [PATCH v2 0/2] Makefile: Generate tag files under $SRC_PATH Fam Zheng
2015-05-22 5:35 ` [Qemu-devel] [PATCH v2 1/2] Makefile: Fix "make cscope TAGS" Fam Zheng
2015-05-22 5:35 ` [Qemu-devel] [PATCH v2 2/2] Makefile: Add "make ctags" Fam Zheng
2015-06-11 8:41 ` [Qemu-devel] [PATCH v2 0/2] Makefile: Generate tag files under $SRC_PATH Fam Zheng
2015-06-11 18:01 ` John Snow [this message]
2015-06-17 19:38 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5579CCFE.5060200@redhat.com \
--to=jsnow@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).