From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Z36nM-0004ud-5C
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 14:01:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Z36nI-0002bJ-OI
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 14:01:40 -0400
Message-ID: <5579CCFE.5060200@redhat.com>
Date: Thu, 11 Jun 2015 14:01:34 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1432272908-8330-1-git-send-email-famz@redhat.com>
	<20150611084124.GC22459@ad.nay.redhat.com>
In-Reply-To: <20150611084124.GC22459@ad.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Makefile: Generate tag files under
 $SRC_PATH
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org



On 06/11/2015 04:41 AM, Fam Zheng wrote:
> On Fri, 05/22 13:35, Fam Zheng wrote:
> 
> Ping :)
> 
> Fam
> 
>>
>>
>> Fam Zheng (2):
>>   Makefile: Fix "make cscope TAGS"
>>   Makefile: Add "make ctags"
>>
>>  Makefile | 20 +++++++++++++++-----
>>  1 file changed, 15 insertions(+), 5 deletions(-)
>>
>> -- 
>> 2.4.1
>>
>>
> 

Looks good to me -- this has long been a major annoyance of mine when I
want to review code (and zip around) without trying to configure it first.

Reviewed-by: John Snow <jsnow@redhat.com>