From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48086)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z3JoW-0005DC-9x
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 03:55:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z3JoR-0006Jn-Au
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 03:55:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z3JoR-0006Ja-4x
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 03:55:39 -0400
Message-ID: <557A9075.5030409@redhat.com>
Date: Fri, 12 Jun 2015 15:55:33 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1433943783-20125-3-git-send-email-thibaut.collet@6wind.com>
	<20150610173321-mutt-send-email-mst@redhat.com>
	<CABUUfwN4sx6u7PiJ_PPKPqvkw1+JHM5x7=qGYeucx7G36eFdog@mail.gmail.com>
	<20150610180013-mutt-send-email-mst@redhat.com>
	<CABUUfwOMHZivKNyeGafdjdRkYBWHfa6TB5rfOinDAFz+_TwEkA@mail.gmail.com>
	<55791F29.6060000@redhat.com>
	<CABUUfwOAG2R_pYRSvr4K=5cg4Z+56PpVFOan-3hKEzD7=GcvPA@mail.gmail.com>
	<5579228E.1040705@redhat.com>
	<20150611123433-mutt-send-email-mst@redhat.com>
	<CABUUfwMSPtbnRqZ3YcGZsan_yK4dN3DocfHjKd-gwDHm7ZbxJg@mail.gmail.com>
	<20150611141135-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150611141135-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for
	legacy guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Thibaut Collet <thibaut.collet@6wind.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>



On 06/11/2015 08:13 PM, Michael S. Tsirkin wrote:
> On Thu, Jun 11, 2015 at 02:10:48PM +0200, Thibaut Collet wrote:
>> I am not sure to understand your remark:
>>
>>> It needs to be sent when backend is activated by guest kick
>>> (in case of virtio 1, it's possible to use DRIVER_OK for this).
>>> This does not happen when VM still runs on source.
>> Could you confirm rarp can be sent by backend when the 
>> VHOST_USER_SET_VRING_KICK message is received by the backend ?
> No - the time to send pakets is when you start processing
> the rings.
>
> And the time to do that is when you detect a kick on
> an eventfd, not when said fd is set.
>

Probably not. What if guest is only doing receiving? In this case, you
won't detect any kick if you don't send the rarp first.