From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Pk2-0008LH-JW for qemu-devel@nongnu.org; Fri, 12 Jun 2015 10:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Pk1-0006U8-Kw for qemu-devel@nongnu.org; Fri, 12 Jun 2015 10:15:30 -0400 Message-ID: <557AE974.9080607@redhat.com> Date: Fri, 12 Jun 2015 16:15:16 +0200 From: Max Reitz MIME-Version: 1.0 References: <1433944027-28533-1-git-send-email-kwolf@redhat.com> <1433944027-28533-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1433944027-28533-8-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, armbru@redhat.com, qemu-devel@nongnu.org On 10.06.2015 15:47, Kevin Wolf wrote: > Instead of manually parsing options and then deleting them from the > options QDict, just use QemuOpts like most other places that deal with > block device options. > > More options will be added there and then QemuOpts is a lot more > managable than open-coding everything. > > Signed-off-by: Kevin Wolf > --- > block.c | 39 ++++++++++++++++++++++++++++++++++----- > 1 file changed, 34 insertions(+), 5 deletions(-) Reviewed-by: Max Reitz