Re: [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Commit 87a560c4 added it in the wrong place.  Commit 59a2c4ce added it
> in the right place, but didn't remove it from the wrong place.  Do
> that now.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/qapi-code-gen.txt | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
> index 3f0522e..61b5be4 100644
> --- a/docs/qapi-code-gen.txt
> +++ b/docs/qapi-code-gen.txt
> @@ -680,8 +680,6 @@ Example:
>      out:
>          error_propagate(errp, err);
>      }
> -    $ python scripts/qapi-commands.py --output-dir="qapi-generated" \
> -    --prefix="example-" example-schema.json
>      $ cat qapi-generated/example-qapi-visit.h
>  [Uninteresting stuff omitted...]

I did a double take there before realizing it was context of the
existing file, and not you hand-editing your patch email :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]