From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Xny-00085Z-6w for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Xnt-0006cR-Ea for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:52:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Xnt-0006cM-9h for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:52:01 -0400 Message-ID: <557B628F.1040704@redhat.com> Date: Fri, 12 Jun 2015 16:51:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434120674-8122-1-git-send-email-armbru@redhat.com> <1434120674-8122-3-git-send-email-armbru@redhat.com> In-Reply-To: <1434120674-8122-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ujXc8QQ0chJ1cvHsP9rhON0e1r0MbNjgg" Subject: Re: [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ujXc8QQ0chJ1cvHsP9rhON0e1r0MbNjgg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/12/2015 08:51 AM, Markus Armbruster wrote: > Commit 87a560c4 added it in the wrong place. Commit 59a2c4ce added it > in the right place, but didn't remove it from the wrong place. Do > that now. >=20 > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 2 -- > 1 file changed, 2 deletions(-) >=20 Reviewed-by: Eric Blake > diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt > index 3f0522e..61b5be4 100644 > --- a/docs/qapi-code-gen.txt > +++ b/docs/qapi-code-gen.txt > @@ -680,8 +680,6 @@ Example: > out: > error_propagate(errp, err); > } > - $ python scripts/qapi-commands.py --output-dir=3D"qapi-generated" = \ > - --prefix=3D"example-" example-schema.json > $ cat qapi-generated/example-qapi-visit.h > [Uninteresting stuff omitted...] I did a double take there before realizing it was context of the existing file, and not you hand-editing your patch email :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ujXc8QQ0chJ1cvHsP9rhON0e1r0MbNjgg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVe2KPAAoJEKeha0olJ0Nq7lMH/RNiVrdHQD4hLrkS0rPqS5oU VhffteOTOdbYfSEEqAZy1I4HAvvgXYgIRAu1K33o1Q2C/4jtaK13fLozAqWpAUEi E7ImnLlG13lF3AQwqqSTNNHCmCoyRl5OvFuGr4MaF/7mdz0m2iXNGCTTmp0VcvfW Igx+GZkgo6Y27omYsO7LbJlQTmuDYWebDcJuLrLCys+sLecE/kl17hN9FRY3FCMF pjMNubTvJc6BD9H0t9A6wzpbMjpNU+vN4bHVrSqfN/QYkn2aGpjal1kjQ+3XfFCX Rs1Arv3RC2rPQe/V48RKQG2VuuQJtYysXygEhV2IqxKZHkHmykLnFTpIJv1DUeM= =+npr -----END PGP SIGNATURE----- --ujXc8QQ0chJ1cvHsP9rhON0e1r0MbNjgg--