From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Y77-0000hi-Pl for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:11:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Y74-00051B-JC for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:11:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Y74-000514-DJ for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:11:50 -0400 Message-ID: <557B6730.8050001@redhat.com> Date: Fri, 12 Jun 2015 17:11:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434120674-8122-1-git-send-email-armbru@redhat.com> <1434120674-8122-5-git-send-email-armbru@redhat.com> In-Reply-To: <1434120674-8122-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xe0vQgKbo1hjeKmmSMCFKM9NkXgTIhqqs" Subject: Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xe0vQgKbo1hjeKmmSMCFKM9NkXgTIhqqs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/12/2015 08:51 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 Ah, I see - you're changing it from an object member to a local variable (because it didn't need to persist beyond the one function). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xe0vQgKbo1hjeKmmSMCFKM9NkXgTIhqqs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVe2cwAAoJEKeha0olJ0Nqbc8H/0SH70wsRzhn2eCd9CmUpc4h 31rtMKGYnG1fdmhTcY6Q9jMkVTlXvBE9LAtQ7uCi3jOiRxrUkAShXMkyqoKbnwsO 59+MJrlv7BXdPCD3t9YBrZQXADxqZ/tQ1Trv3BgrTx2w5MouzhZeip4Qa2WVH+Fr FCH0QYi8xDUrOVoAhuwzN4ktpj5qeR/0na1sEFh8wetqT0qcHLrIh205kVdwdlMp lw4IRPL/NPxXFCLiTbZawdCX6siDaB+Ljw73It4irQaTRxVDmtQ+2ftZNF7xbMIm tTke6Ce0HOB+sYcaSGyTVBzMX6Hh4Tys8u0HONmfPdYjJObk7cR1Zc4srwZK0Jw= =VKBN -----END PGP SIGNATURE----- --Xe0vQgKbo1hjeKmmSMCFKM9NkXgTIhqqs--