From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3YUL-0006pW-HG for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:35:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3YUG-0004AU-Px for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:35:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3YUG-0004AF-ED for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:35:48 -0400 Message-ID: <557B6CD2.70706@redhat.com> Date: Fri, 12 Jun 2015 17:35:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434120674-8122-1-git-send-email-armbru@redhat.com> <1434120674-8122-9-git-send-email-armbru@redhat.com> In-Reply-To: <1434120674-8122-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u4G8eAGkcoRw2No81aqTLRkum9gVmULGu" Subject: Re: [Qemu-devel] [PATCH 08/16] qapi: Fix to reject stray 't', 'f' and 'n' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u4G8eAGkcoRw2No81aqTLRkum9gVmULGu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/12/2015 08:51 AM, Markus Armbruster wrote: > Screwed up in commit e53188a. >=20 And partly my fault for taking a patch written in python by someone else, without being a python guru myself. :) > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) >=20 Is it worth a testsuite enhancement to expose this? > + elif self.src.startswith("true", self.pos): > + self.val =3D True > + self.cursor +=3D 3 > + return > + elif self.src.startswith("false", self.pos): We still parse things like bare 'truest' as the token 'true' concatenated with the nonsense 'st', which is probably not the nicest of error messages, but the chances of someone mistyping bare words is not worth making it more robust. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --u4G8eAGkcoRw2No81aqTLRkum9gVmULGu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVe2zSAAoJEKeha0olJ0NqsEcIAJ1iY/xwaJhfh8rD8wUXWONS 9JtZ7mIkLlYmkuSsy7JNFCtbpuViVlXFc4/62eG8Dp/+5yiZFypEksSNvpSUILqT XSHmRtmf/Xaa/spkEGAFGudA5mtN7OxXTQ5EkPe7inqauTy+2Iw1+/fjmmOB4zIe C6DvLTrb/u62nappoNn3fP78H1CSMqCP66SlwFwbt6vFPbOjUL/d22JFCIC10REx OJ2bIzQo0gCTDe9utwvOGPZa/klmi5LCl1yY7L/d5pVyDjzaGMlA4BdmlzQemaqH 3h13kAGlY9Bni3WjXvZKLAeczjWuIUMusl3x60riidFUL+IrkXRvqtWxwAQd51c= =NF0t -----END PGP SIGNATURE----- --u4G8eAGkcoRw2No81aqTLRkum9gVmULGu--