From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3yJ8-0003Ub-ST for qemu-devel@nongnu.org; Sat, 13 Jun 2015 23:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3yJ3-0002IH-VY for qemu-devel@nongnu.org; Sat, 13 Jun 2015 23:10:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3yJ3-0002I1-PU for qemu-devel@nongnu.org; Sat, 13 Jun 2015 23:09:57 -0400 Message-ID: <557CF07D.3040401@redhat.com> Date: Sat, 13 Jun 2015 21:09:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-3-git-send-email-armbru@redhat.com> In-Reply-To: <1434205258-1932-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X0wCkD4o4cT650EnxL51JENqtoGTeB3Vk" Subject: Re: [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP command handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X0wCkD4o4cT650EnxL51JENqtoGTeB3Vk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2015 08:20 AM, Markus Armbruster wrote: > qerror_report() is a transitional interface to help with converting > existing monitor commands to QMP. It should not be used elsewhere. > Replace by error_report() in initial startup helpers parse_sandbox() > and parse_add_fd(). >=20 > Signed-off-by: Markus Armbruster > --- > vl.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-) >=20 > #else > - qerror_report(ERROR_CLASS_GENERIC_ERROR, > - "sandboxing request but seccomp is not compiled = into this build"); > + error_report("sandboxing request but seccomp is not compiled "= > + "into this build"); Pre-existing, but s/request/requested/ would sound better while touching this. Either way, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --X0wCkD4o4cT650EnxL51JENqtoGTeB3Vk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVfPB9AAoJEKeha0olJ0NqEqsH/1kh6dEx70EVCWaw2ZrkgOi5 B9PtmlKYDtfBQzcIvKoZQdS3wrJjpuxcIgUVzi9T09ZrJ5206JhMytXeB3Fn830W E+uqbTHENXdDpyFTdyTRCM6nukLVCcpK03w+KHEW6VCdKd6yrXpzhNOT2vfqi/tT CSQWwcrKR2ZRhoM7KTzW3Pg7C/756EIkEXU0DyKWy/tGM0TUWScV2NZ3w3wD2KQ+ Utq6KxRjhsjjpsg8dUjE/2C2cHwSiqTSC+ecHyzesjh9tg9dt1HsUQ/0B6eQOIP2 EiAN0ojRMnoPuKGBdUoiV7KiscZQgZKGFyhHwLG3tUOe2PEa3TqFmIib4R03y00= =wgW3 -----END PGP SIGNATURE----- --X0wCkD4o4cT650EnxL51JENqtoGTeB3Vk--