From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4bZa-0006lN-VP for qemu-devel@nongnu.org; Mon, 15 Jun 2015 17:05:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4bZT-0003IR-0W for qemu-devel@nongnu.org; Mon, 15 Jun 2015 17:05:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4bZS-0003IL-SX for qemu-devel@nongnu.org; Mon, 15 Jun 2015 17:05:30 -0400 Message-ID: <557F3E19.6080506@redhat.com> Date: Mon, 15 Jun 2015 15:05:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-9-git-send-email-armbru@redhat.com> In-Reply-To: <1434205258-1932-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tuG2I8PSqnvBp4mLv8HsMXllSBb6HveM9" Subject: Re: [Qemu-devel] [PATCH 08/11] qerror: Finally unused, clean up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tuG2I8PSqnvBp4mLv8HsMXllSBb6HveM9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2015 08:20 AM, Markus Armbruster wrote: > Remove it except for two things in qerror.h: >=20 > * Two #include to be cleaned up separately to avoid cluttering this > patch. >=20 > * The QERR_ macros. Mark as obsolete. >=20 > Signed-off-by: Markus Armbruster > --- > block/qapi.c | 6 -- > include/monitor/monitor.h | 1 - > include/qapi/qmp/qerror.h | 19 +----- > include/qapi/qmp/qobject.h | 1 - > monitor.c | 13 ---- > qobject/Makefile.objs | 1 - > qobject/qerror.c | 148 -------------------------------------= -------- > qobject/qjson.c | 3 - > stubs/Makefile.objs | 1 - > stubs/mon-is-qmp.c | 2 + > stubs/mon-set-error.c | 8 --- > 11 files changed, 4 insertions(+), 199 deletions(-) > delete mode 100644 qobject/qerror.c > delete mode 100644 stubs/mon-set-error.c >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tuG2I8PSqnvBp4mLv8HsMXllSBb6HveM9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVfz4ZAAoJEKeha0olJ0NqbLsIAIhUfxNbVDQ5g1vJBg1kubsW phnEIBFHp259g+YlMU6NafDzwYCiG1d3ZNejd84HqMtASvCtvIATt9tYPLg8fivY WGt3pCqriReB6GpAY+DSMEpF0JSjkSYr7mZUMFntb3M9KcyXDate6QuxZzted0uV P1Fo+yLppH+bnV4elu1KLrAiGX0+v6cOFRKO08up8MDdqaiWySAQv9I0wRtr7Kdt 7G3xpT41UT4+Lmjomi7OC5oGsIMiqF8eQg1qTKWH72Af1dOXFYo+jOeIw81raMEf awHFM+xBGnSHWDjzMZa+sFLh1w0xr40iS3ulAPyaZRjjjcDdgcju48umda1eKmE= =nvH7 -----END PGP SIGNATURE----- --tuG2I8PSqnvBp4mLv8HsMXllSBb6HveM9--