From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4c7T-0005kN-7x for qemu-devel@nongnu.org; Mon, 15 Jun 2015 17:40:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4c7O-0001IP-8V for qemu-devel@nongnu.org; Mon, 15 Jun 2015 17:40:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4c7O-0001Hx-1m for qemu-devel@nongnu.org; Mon, 15 Jun 2015 17:40:34 -0400 Message-ID: <557F4650.1050807@redhat.com> Date: Mon, 15 Jun 2015 15:40:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-12-git-send-email-armbru@redhat.com> In-Reply-To: <1434205258-1932-12-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eKVb9fegUwmrSP6aCTMeA9kjw3XWfo6Il" Subject: Re: [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eKVb9fegUwmrSP6aCTMeA9kjw3XWfo6Il Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2015 08:20 AM, Markus Armbruster wrote: > In particular, don't include it into headers. >=20 > Signed-off-by: Markus Armbruster > --- > 29 files changed, 4 insertions(+), 29 deletions(-) Again, it might be nice to call out in the commit message how you determined which files could drop it (was it via blanket deletion, then re-add if compilation failed?). But doesn't impact the patch being a nice cleanup, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eKVb9fegUwmrSP6aCTMeA9kjw3XWfo6Il Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVf0ZQAAoJEKeha0olJ0NqxnsH/iRWliyXR3CBg3VKxrWEommH 0ec2ZbqiYxclkQGGuXqjl0KhGOE2puFrXe/dTE8hcJrL+xkJsQuG/BCMia9XwpzM yWHwh63Y4OSLSnz6Dob7YOqsnrCZe3ESizXZc7TUIv8ft10bVcwnXjzHfNpYc4Rg wc0QpKQ502B2G5wTPw31IdjoxH7Z6qN0iQgmwNt8hk8QglTN5ECzMwFbx4S0Ibf0 Hewyi+4UcJ6T5WF+voANj+GEvOHyOUIB/KvYJ+8qEWpwexbeGaZkPPdKf6p8bNYM 2HyJsPoM1ACw5/PkhDIDOQAF1AqN1WJ/oxEed1ouNpttCeqYrPJ/gRfWELqhggg= =lWqj -----END PGP SIGNATURE----- --eKVb9fegUwmrSP6aCTMeA9kjw3XWfo6Il--