From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org,
n.nikolaev@virtualopensystems.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 3/4] vhost-user: Enable 'nowait' and 'reconnect' option
Date: Tue, 16 Jun 2015 14:08:41 +0900 [thread overview]
Message-ID: <557FAF59.5040601@igel.co.jp> (raw)
In-Reply-To: <20150615135859.GE9410@stefanha-thinkpad.redhat.com>
On 2015/06/15 22:58, Stefan Hajnoczi wrote:
> On Fri, May 29, 2015 at 01:42:29PM +0900, Tetsuya Mukawa wrote:
>> The patch enables 'nowait' option for server mode, and 'reconnect'
>> option for client mode.
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
>> ---
>> net/vhost-user.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/net/vhost-user.c b/net/vhost-user.c
>> index 1967ff4..f823d78 100644
>> --- a/net/vhost-user.c
>> +++ b/net/vhost-user.c
>> @@ -26,6 +26,8 @@ typedef struct VhostUserChardevProps {
>> bool is_socket;
>> bool is_unix;
>> bool is_server;
>> + bool is_nowait;
>> + bool is_reconnect;
>> } VhostUserChardevProps;
>>
>> VHostNetState *vhost_user_get_vhost_net(NetClientState *nc)
>> @@ -178,6 +180,10 @@ static int net_vhost_chardev_opts(const char *name, const char *value,
>> props->is_unix = true;
>> } else if (strcmp(name, "server") == 0) {
>> props->is_server = true;
>> + } else if ((strcmp(name, "wait") == 0) && (strcmp(value, "off")) == 0) {
>> + props->is_nowait = true;
>> + } else if (strcmp(name, "reconnect") == 0) {
>> + props->is_reconnect = true;
> Where is the code that uses these new options?
Above code is only for allowing below QEMU options.
-chardev socket,id=chr0,path=/tmp/sock,reconnect=3
-chardev socket,id=chr0,path=/tmp/sock,server,nowait
These options are needed, because we don't want to wait for vhost-user
backend connection.
Regards,
Tetsuya
next prev parent reply other threads:[~2015-06-16 5:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 7:28 [Qemu-devel] [RFC PATCH 0/4] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 1/4] vhost-user: Add ability to know vhost-user backend disconnection Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 2/4] vhost-user: Shutdown vhost-user connection when wrong messages are passed Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 3/4] vhost-user: Enable 'nowait' and 'reconnect' option Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 4/4] vhost-user: Add new option to specify vhost-user backend supports Tetsuya Mukawa
2015-05-25 22:11 ` Eric Blake
2015-05-26 2:46 ` Tetsuya Mukawa
2015-05-26 4:29 ` Tetsuya Mukawa
2015-05-26 12:52 ` Eric Blake
2015-05-28 1:25 ` Tetsuya Mukawa
2015-05-29 4:42 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 1/4] vhost-user: Add ability to know vhost-user backend disconnection Tetsuya Mukawa
2015-06-15 13:32 ` Stefan Hajnoczi
2015-06-16 5:07 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 2/4] vhost-user: Shutdown vhost-user connection when wrong messages are passed Tetsuya Mukawa
2015-06-15 13:40 ` Stefan Hajnoczi
2015-06-16 5:08 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 3/4] vhost-user: Enable 'nowait' and 'reconnect' option Tetsuya Mukawa
2015-06-15 13:41 ` Stefan Hajnoczi
2015-06-15 13:58 ` Stefan Hajnoczi
2015-06-16 5:08 ` Tetsuya Mukawa [this message]
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 4/4] vhost-user: Add new option to specify vhost-user backend features Tetsuya Mukawa
2015-06-15 13:58 ` Stefan Hajnoczi
2015-06-16 5:08 ` Tetsuya Mukawa
2015-06-16 12:27 ` Eric Blake
2015-06-17 9:29 ` Tetsuya Mukawa
2015-06-11 1:56 ` [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-06-15 14:12 ` Stefan Hajnoczi
2015-06-15 14:21 ` Michael S. Tsirkin
2015-06-15 14:08 ` Stefan Hajnoczi
2015-06-16 5:09 ` Tetsuya Mukawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557FAF59.5040601@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=n.nikolaev@virtualopensystems.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).