From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org,
n.nikolaev@virtualopensystems.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend
Date: Tue, 16 Jun 2015 14:09:24 +0900 [thread overview]
Message-ID: <557FAF84.4040507@igel.co.jp> (raw)
In-Reply-To: <20150615140838.GF9410@stefanha-thinkpad.redhat.com>
On 2015/06/15 23:08, Stefan Hajnoczi wrote:
> On Fri, May 29, 2015 at 01:42:26PM +0900, Tetsuya Mukawa wrote:
>> - Change user interface to be able to specify each feature by name.
> I disagree with this change, the uint64_t backend_features option was
> better because:
>
> The text options will just result in a very long command-line that is
> hard to read for humans. Instead of checking a bit in a single hex
> number, you have to scan over long comma-separated text options which
> can be in any arbitrary order to find the feature bit you were looking
> for.
>
> This option needs to be scripted or generated by a management tool
> anyway since it depends on the vhost-user backend program that is being
> paired with QEMU. The number of human users constructing these option
> is extremely low - if they use it they'll copy-paste it from their
> vhost-user program's documentation so the contents don't matter much
> (shorter is better though).
>
> The text options must be updated when new feature bits are added to
> virtio-net.
>
> For these reasons I find the numeric backend_features option better.
Thanks for comments.
I guess it's reasonable, so I will revert it in next patches.
Regards,
Tetsuya
prev parent reply other threads:[~2015-06-16 5:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 7:28 [Qemu-devel] [RFC PATCH 0/4] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 1/4] vhost-user: Add ability to know vhost-user backend disconnection Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 2/4] vhost-user: Shutdown vhost-user connection when wrong messages are passed Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 3/4] vhost-user: Enable 'nowait' and 'reconnect' option Tetsuya Mukawa
2015-05-25 7:28 ` [Qemu-devel] [RFC PATCH 4/4] vhost-user: Add new option to specify vhost-user backend supports Tetsuya Mukawa
2015-05-25 22:11 ` Eric Blake
2015-05-26 2:46 ` Tetsuya Mukawa
2015-05-26 4:29 ` Tetsuya Mukawa
2015-05-26 12:52 ` Eric Blake
2015-05-28 1:25 ` Tetsuya Mukawa
2015-05-29 4:42 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 1/4] vhost-user: Add ability to know vhost-user backend disconnection Tetsuya Mukawa
2015-06-15 13:32 ` Stefan Hajnoczi
2015-06-16 5:07 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 2/4] vhost-user: Shutdown vhost-user connection when wrong messages are passed Tetsuya Mukawa
2015-06-15 13:40 ` Stefan Hajnoczi
2015-06-16 5:08 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 3/4] vhost-user: Enable 'nowait' and 'reconnect' option Tetsuya Mukawa
2015-06-15 13:41 ` Stefan Hajnoczi
2015-06-15 13:58 ` Stefan Hajnoczi
2015-06-16 5:08 ` Tetsuya Mukawa
2015-05-29 4:42 ` [Qemu-devel] [PATCH v1 4/4] vhost-user: Add new option to specify vhost-user backend features Tetsuya Mukawa
2015-06-15 13:58 ` Stefan Hajnoczi
2015-06-16 5:08 ` Tetsuya Mukawa
2015-06-16 12:27 ` Eric Blake
2015-06-17 9:29 ` Tetsuya Mukawa
2015-06-11 1:56 ` [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-06-15 14:12 ` Stefan Hajnoczi
2015-06-15 14:21 ` Michael S. Tsirkin
2015-06-15 14:08 ` Stefan Hajnoczi
2015-06-16 5:09 ` Tetsuya Mukawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557FAF84.4040507@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=n.nikolaev@virtualopensystems.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).