From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
keithp@keithp.com, "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>
Subject: Re: [PATCH v2 4/5] tests/tcg: add a dumb-as-bricks semihosting console test
Date: Sun, 29 Dec 2019 13:57:26 +1100 [thread overview]
Message-ID: <557f36ea-159f-ebb2-b7aa-e96b0844e1ae@linaro.org> (raw)
In-Reply-To: <20191220132246.6759-5-alex.bennee@linaro.org>
On 12/21/19 12:22 AM, Alex Bennée wrote:
> We don't run this during check-tcg as we would need to check stuff is
> echoed back. However we can still build the binary so people can test
> it manually.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> ---
> v8
> - actually return the result!
> ---
> tests/tcg/aarch64/system/semiconsole.c | 38 +++++++++++++++++++++++
> tests/tcg/aarch64/Makefile.softmmu-target | 9 +++++-
> 2 files changed, 46 insertions(+), 1 deletion(-)
> create mode 100644 tests/tcg/aarch64/system/semiconsole.c
There probably is a way to easily test this with python, but I don't want to
write that script either, so.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
:-)
r~
next prev parent reply other threads:[~2019-12-29 2:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 13:22 [PATCH v2 0/5] semihosting read console support Alex Bennée
2019-12-20 13:22 ` [PATCH v2 1/5] target/arm: remove unused EXCP_SEMIHOST leg Alex Bennée
2019-12-20 13:22 ` [PATCH v2 2/5] target/arm: only update pc after semihosting completes Alex Bennée
2019-12-20 13:22 ` [PATCH v2 3/5] semihosting: add qemu_semihosting_console_inc for SYS_READC Alex Bennée
2019-12-29 2:58 ` Richard Henderson
2019-12-20 13:22 ` [PATCH v2 4/5] tests/tcg: add a dumb-as-bricks semihosting console test Alex Bennée
2019-12-29 2:57 ` Richard Henderson [this message]
2019-12-20 13:22 ` [PATCH v2 5/5] tests/tcg: add user version of dumb-as-bricks semiconsole test Alex Bennée
2019-12-29 2:55 ` Richard Henderson
2020-01-07 14:27 ` Alex Bennée
2020-01-08 1:13 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557f36ea-159f-ebb2-b7aa-e96b0844e1ae@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=keithp@keithp.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).