From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sEF-0005Ci-5g for qemu-devel@nongnu.org; Tue, 16 Jun 2015 10:52:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4sEB-0003cl-OY for qemu-devel@nongnu.org; Tue, 16 Jun 2015 10:52:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sEB-0003cd-KN for qemu-devel@nongnu.org; Tue, 16 Jun 2015 10:52:39 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id EE4972E6DBE for ; Tue, 16 Jun 2015 14:45:06 +0000 (UTC) Message-ID: <55803671.50208@redhat.com> Date: Tue, 16 Jun 2015 08:45:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434458200-23440-1-git-send-email-mst@redhat.com> <1434458200-23440-2-git-send-email-mst@redhat.com> In-Reply-To: <1434458200-23440-2-git-send-email-mst@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UVkNxQ8TcprjA9hDWHoAK4cXAjx1LvgNB" Subject: Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UVkNxQ8TcprjA9hDWHoAK4cXAjx1LvgNB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > makes it possible to copy error_abort pointers, > not just pass them on directly. >=20 > Signed-off-by: Michael S. Tsirkin > --- > util/error.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) Where is this patch needed? Is the goal to allow: Error err =3D error_abort; as a way to statically initialize err via copy to behave the same as the global error_abort? But that's not how you were using it in patch 3. There, you were initializing Error *, so using &error_abort is still useful there, and pointer equality still suffices. I don't see a convincing use for this patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UVkNxQ8TcprjA9hDWHoAK4cXAjx1LvgNB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVgDZxAAoJEKeha0olJ0Nq22MH/RcSd0jK1hCjg9Kr1ab9muXu mWgOutZHrhmd8N19AQdeVyP5fhg58teiSx5gg7ihTL6y0cIfDZeoqDGt1K6g5mOe BVcN3FiG4+b0bvgdhhVv+Qk3kyHN037D4C8AXsFt1ktuD1LrLZm/eNcxbu2/M2PD Qx/ShO1xKmVgYHsmrsaBUehmY3MEsabxv8HCSUXWiIjhhPf3too/432kabUS7dEf lRG29DzYZThiHlHjN6ZDic7QoerQnRWipXGLNC4q2i/uFaNl8E0Sqd6nRUmTfLVZ tLyo7NgAZu29Xsy3COqNmRklu9byAszi13XYLDn51x6UOaK0rLxc0FYBEkgrWlw= =fezq -----END PGP SIGNATURE----- --UVkNxQ8TcprjA9hDWHoAK4cXAjx1LvgNB--