From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z58Dd-0003Lx-0y
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 03:57:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z58DY-0002XU-SD
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 03:57:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41345)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z58DY-0002XP-Mn
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 03:57:04 -0400
Message-ID: <5581284B.7040208@redhat.com>
Date: Wed, 17 Jun 2015 09:56:59 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1433351328-23326-1-git-send-email-pbonzini@redhat.com>	<1433351328-23326-9-git-send-email-pbonzini@redhat.com>	<CAEgOgz69DOJ0P3o9M1TYk-SyMJMiF1374p8my_iPNQ9fs+cLkw@mail.gmail.com>
	<55700630.7090006@redhat.com> <55772B9F.6040300@twiddle.net>
In-Reply-To: <55772B9F.6040300@twiddle.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style
 MMIO accessors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Laszlo Ersek <lersek@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>



On 09/06/2015 20:08, Richard Henderson wrote:
> > > +    bool be = !!(pfl->features & (1 << PFLASH_BE));
> > >
> > > !!() not needed. Otherwise
> > 
> > I don't like magic bool-ification...
> 
> I don't like !! just as much.  If you don't like implicit conversion, then use
> != 0.

Fair enough, let's add to the coding still that we don't like !!.

Paolo