From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z59vO-0003Jz-NE for qemu-devel@nongnu.org; Wed, 17 Jun 2015 05:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z59vL-0003j5-3R for qemu-devel@nongnu.org; Wed, 17 Jun 2015 05:46:26 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:33575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z59vK-0003iG-TH for qemu-devel@nongnu.org; Wed, 17 Jun 2015 05:46:23 -0400 Received: by wiwd19 with SMTP id d19so127665346wiw.0 for ; Wed, 17 Jun 2015 02:46:22 -0700 (PDT) Message-ID: <558141EA.2080505@gmail.com> Date: Wed, 17 Jun 2015 12:46:18 +0300 From: Marcel Apfelbaum MIME-Version: 1.0 References: <97ef23adf1c72506bd054f53ca208b9e094a74f6.1434356309.git.chen.fan.fnst@cn.fujitsu.com> In-Reply-To: <97ef23adf1c72506bd054f53ca208b9e094a74f6.1434356309.git.chen.fan.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v10 17/19] pcie_aer: expose pcie_aer_msg() interface Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan , qemu-devel@nongnu.org Cc: izumi.taku@jp.fujitsu.com, alex.williamson@redhat.com On 06/16/2015 11:11 AM, Chen Fan wrote: > For vfio device, we need to propagate the aer error to > Guest OS. we use the pcie_aer_msg() to send aer error > to guest. > > Signed-off-by: Chen Fan > --- > hw/pci/pcie_aer.c | 2 +- > include/hw/pci/pcie_aer.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c > index 6171a29..373d1f2 100644 > --- a/hw/pci/pcie_aer.c > +++ b/hw/pci/pcie_aer.c > @@ -370,7 +370,7 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const PCIEAERMsg *msg) > * > * Walk up the bus tree from the device, propagate the error message. > */ > -static void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg) > +void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg) > { > uint8_t type; > > diff --git a/include/hw/pci/pcie_aer.h b/include/hw/pci/pcie_aer.h > index 156acb0..c2ee4e2 100644 > --- a/include/hw/pci/pcie_aer.h > +++ b/include/hw/pci/pcie_aer.h > @@ -102,5 +102,6 @@ void pcie_aer_root_write_config(PCIDevice *dev, > > /* error injection */ > int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err); > +void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg); > > #endif /* QEMU_PCIE_AER_H */ > Assuming the pcie_aer_msg will be used (after all reviews): Reviewed-by: Marcel Apfelbaum Thanks, Marcel